From 7b67e7296ad1d427672a7b0c29f0c7411d01d90f Mon Sep 17 00:00:00 2001 From: i0brendan0 <19826742+i0brendan0@users.noreply.github.com> Date: Wed, 30 Aug 2017 20:56:11 -0500 Subject: [PATCH 1/3] Remove possibility of garbage characters If the ds 2 that is behind OTClassName is deleted or decreased, the game will continue to display characters for trainer classes that are 12 or 13 characters long, including the @ terminator. The correct constant has been put in place and the ds 2 removed, but no one would have known it was wrong if they hadn't have removed the ds 2. --- wram.asm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/wram.asm b/wram.asm index 663f57893..9e30d0beb 100644 --- a/wram.asm +++ b/wram.asm @@ -379,9 +379,7 @@ wEnemyTrainerItem1:: ds 1 ; c650 wEnemyTrainerItem2:: ds 1 ; c651 wEnemyTrainerBaseReward:: ds 1 ; c652 wEnemyTrainerAIFlags:: ds 3 ; c653 -OTClassName:: ds NAME_LENGTH ; c656 - - ds 2 +OTClassName:: ds TRAINER_CLASS_NAME_LENGTH ; c656 CurOTMon:: ; c663 ds 1 From a497ca3c2e014355c958fd8381b51a9e917969fc Mon Sep 17 00:00:00 2001 From: luckytyphlosion Date: Mon, 4 Sep 2017 19:25:37 -0400 Subject: [PATCH 2/3] Add other Discord and disassembly links. --- README.md | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 6a5cef33e..510986d49 100644 --- a/README.md +++ b/README.md @@ -9,8 +9,19 @@ It builds the following roms: To set up the repository, see [INSTALL.md](INSTALL.md). -### irc: [freenode#pret][irc] +## See also +* Disassembly of [**Pokémon Red/Blue**][pokered] +* Disassembly of [**Pokémon Yellow**][pokeyellow] +* Disassembly of [**Pokémon Pinball**][pokepinball] +* Disassembly of [**Pokémon TCG**][poketcg] +* Discord: [**pret**][Discord] +* irc: [freenode#pret][irc] +[pokered]: https://github.com/pret/pokered +[pokeyellow]: https://github.com/pret/pokeyellow +[pokepinball]: https://github.com/pret/pokepinball +[poketcg]: https://github.com/pret/poketcg +[Discord]: https://discord.gg/cJxDDVP [irc]: https://kiwiirc.com/client/irc.freenode.net/?#pret [travis]: https://travis-ci.org/pret/pokecrystal [travis-badge]: https://travis-ci.org/pret/pokecrystal.svg?branch=master From 7c6932fbae357f0e514516a8f3468783efa93c65 Mon Sep 17 00:00:00 2001 From: luckytyphlosion Date: Mon, 4 Sep 2017 19:41:13 -0400 Subject: [PATCH 3/3] Add Gen 3 disassemblies. --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 510986d49..5ec1bbf73 100644 --- a/README.md +++ b/README.md @@ -14,6 +14,8 @@ To set up the repository, see [INSTALL.md](INSTALL.md). * Disassembly of [**Pokémon Yellow**][pokeyellow] * Disassembly of [**Pokémon Pinball**][pokepinball] * Disassembly of [**Pokémon TCG**][poketcg] +* Disassembly of [**Pokémon Ruby**][pokeruby] +* Disassembly of [**Pokémon Emerald**][pokeemerald] * Discord: [**pret**][Discord] * irc: [freenode#pret][irc] @@ -21,6 +23,8 @@ To set up the repository, see [INSTALL.md](INSTALL.md). [pokeyellow]: https://github.com/pret/pokeyellow [pokepinball]: https://github.com/pret/pokepinball [poketcg]: https://github.com/pret/poketcg +[pokeruby]: https://github.com/pret/pokeruby +[pokeemerald]: https://github.com/pret/pokeemerald [Discord]: https://discord.gg/cJxDDVP [irc]: https://kiwiirc.com/client/irc.freenode.net/?#pret [travis]: https://travis-ci.org/pret/pokecrystal