pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2025-04-09 05:44:44 -07:00
Code Issues Packages Projects Releases Wiki Activity

Verify data table sizes with table_width and assert_table_length macros

Browse Source 
This was discussed in #706

It also uncovered some off-by-one issues with defining some constants.

A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
This commit is contained in:
Rangi
2021-03-03 22:22:41 -05:00
parent 9c17fb14c8
commit 40902ffe24
148 changed files with 608 additions and 237 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gfx/footprints.asm
View File

@@ -9,6 +9,8 @@ footprint_bottom EQUS "2 * LEN_1BPP_TILE, 2 * LEN_1BPP_TILE"
; Entries correspond to Pokémon species, two apiece, 8 tops then 8 bottoms
table_width LEN_1BPP_TILE * 4, Footprints
; 001-008 top halves
INCBIN "gfx/footprints/bulbasaur.1bpp", footprint_top
INCBIN "gfx/footprints/ivysaur.1bpp", footprint_top
@@ -585,3 +587,5 @@ INCBIN "gfx/footprints/253.1bpp", footprint_bottom
INCBIN "gfx/footprints/254.1bpp", footprint_bottom
INCBIN "gfx/footprints/255.1bpp", footprint_bottom
INCBIN "gfx/footprints/256.1bpp", footprint_bottom
assert_table_length $100

2
gfx/pokemon/anim_pointers.asm
View File

@@ -1,4 +1,5 @@
AnimationPointers:
table_width 2, AnimationPointers
dw BulbasaurAnimation
dw IvysaurAnimation
dw VenusaurAnimation
@@ -250,3 +251,4 @@ AnimationPointers:
dw LugiaAnimation
dw HoOhAnimation
dw CelebiAnimation
assert_table_length NUM_POKEMON

2
gfx/pokemon/bitmask_pointers.asm
View File

@@ -1,4 +1,5 @@
BitmasksPointers:
table_width 2, BitmasksPointers
dw BulbasaurBitmasks
dw IvysaurBitmasks
dw VenusaurBitmasks
@@ -250,3 +251,4 @@ BitmasksPointers:
dw LugiaBitmasks
dw HoOhBitmasks
dw CelebiBitmasks
assert_table_length NUM_POKEMON

2
gfx/pokemon/frame_pointers.asm
View File

@@ -1,4 +1,5 @@
FramesPointers:
table_width 2, FramesPointers
dw BulbasaurFrames
dw IvysaurFrames
dw VenusaurFrames
@@ -250,3 +251,4 @@ FramesPointers:
dw LugiaFrames
dw HoOhFrames
dw CelebiFrames
assert_table_length NUM_POKEMON

2
gfx/pokemon/idle_pointers.asm
View File

@@ -1,4 +1,5 @@
AnimationIdlePointers:
table_width 2, AnimationIdlePointers
dw BulbasaurAnimationIdle
dw IvysaurAnimationIdle
dw VenusaurAnimationIdle
@@ -250,3 +251,4 @@ AnimationIdlePointers:
dw LugiaAnimationIdle
dw HoOhAnimationIdle
dw CelebiAnimationIdle
assert_table_length NUM_POKEMON

2
gfx/pokemon/unown_anim_pointers.asm
View File

@@ -1,4 +1,5 @@
UnownAnimationPointers:
table_width 2, UnownAnimationPointers
dw UnownAAnimation
dw UnownBAnimation
dw UnownCAnimation
@@ -25,3 +26,4 @@ UnownAnimationPointers:
dw UnownXAnimation
dw UnownYAnimation
dw UnownZAnimation
assert_table_length NUM_UNOWN

2
gfx/pokemon/unown_bitmask_pointers.asm
View File

@@ -1,4 +1,5 @@
UnownBitmasksPointers:
table_width 2, UnownBitmasksPointers
dw UnownABitmasks
dw UnownBBitmasks
dw UnownCBitmasks
@@ -25,3 +26,4 @@ UnownBitmasksPointers:
dw UnownXBitmasks
dw UnownYBitmasks
dw UnownZBitmasks
assert_table_length NUM_UNOWN

2
gfx/pokemon/unown_frame_pointers.asm
View File

@@ -1,4 +1,5 @@
UnownFramesPointers:
table_width 2, UnownFramesPointers
dw UnownAFrames
dw UnownBFrames
dw UnownCFrames
@@ -25,3 +26,4 @@ UnownFramesPointers:
dw UnownXFrames
dw UnownYFrames
dw UnownZFrames
assert_table_length NUM_UNOWN

2
gfx/pokemon/unown_idle_pointers.asm
View File

@@ -1,4 +1,5 @@
UnownAnimationIdlePointers:
table_width 2, UnownAnimationIdlePointers
dw UnownAAnimationIdle
dw UnownBAnimationIdle
dw UnownCAnimationIdle
@@ -25,3 +26,4 @@ UnownAnimationIdlePointers:
dw UnownXAnimationIdle
dw UnownYAnimationIdle
dw UnownZAnimationIdle
assert_table_length NUM_UNOWN