You've already forked pokecrystal-board
mirror of
https://gitlab.com/xCrystal/pokecrystal-board.git
synced 2025-04-09 05:44:44 -07:00
Verify data table sizes with table_width and assert_table_length macros
This was discussed in #706 It also uncovered some off-by-one issues with defining some constants. A few structs now use rsreset/_RS to define their offset constants, as discussed in #739
This commit is contained in:
@@ -1805,7 +1805,7 @@ Pokedex_PrevSearchMonType:
|
||||
jr .done
|
||||
|
||||
.wrap_around
|
||||
ld [hl], NUM_TYPES - 1
|
||||
ld [hl], NUM_TYPES
|
||||
|
||||
.done
|
||||
scf
|
||||
@@ -1818,7 +1818,7 @@ Pokedex_NextSearchMonType:
|
||||
|
||||
ld hl, wDexSearchMonType1
|
||||
ld a, [hl]
|
||||
cp NUM_TYPES - 1
|
||||
cp NUM_TYPES
|
||||
jr nc, .type1_wrap_around
|
||||
inc [hl]
|
||||
jr .done
|
||||
@@ -1829,7 +1829,7 @@ Pokedex_NextSearchMonType:
|
||||
.type2
|
||||
ld hl, wDexSearchMonType2
|
||||
ld a, [hl]
|
||||
cp NUM_TYPES - 1
|
||||
cp NUM_TYPES
|
||||
jr nc, .type2_wrap_around
|
||||
inc [hl]
|
||||
jr .done
|
||||
@@ -1862,7 +1862,7 @@ Pokedex_PlaceTypeString:
|
||||
ld e, a
|
||||
ld d, 0
|
||||
ld hl, PokedexTypeSearchStrings
|
||||
rept 9
|
||||
rept POKEDEX_TYPE_STRING_LENGTH
|
||||
add hl, de
|
||||
endr
|
||||
ld e, l
|
||||
|
Reference in New Issue
Block a user