From 35f6b6e68c8c8a7d164f67e1ae452270a28ac3b7 Mon Sep 17 00:00:00 2001 From: "Colton G. Rushton" Date: Sun, 5 Sep 2021 13:16:06 -0300 Subject: [PATCH] Add multiple design flaw fixes (#848) Fixes https://github.com/pret/pokecrystal/issues/814 Fixes https://github.com/pret/pokecrystal/issues/805 --- docs/design_flaws.md | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/docs/design_flaws.md b/docs/design_flaws.md index f01385948..57119f67e 100644 --- a/docs/design_flaws.md +++ b/docs/design_flaws.md @@ -13,6 +13,8 @@ These are parts of the code that do not work *incorrectly*, like [bugs and glitc - [Pokédex entry banks are derived from their species IDs](#pokédex-entry-banks-are-derived-from-their-species-ids) - [Identical sine wave code and data is repeated five times](#identical-sine-wave-code-and-data-is-repeated-five-times) - [`GetForestTreeFrame` works, but it's still bad](#getforesttreeframe-works-but-its-still-bad) +- [Second rival battle's DVs are lower than the first](#second-rival-battles-dvs-are-lower-than-the-first) +- [The Ruins of Alph research center's roof color at night looks wrong](#the-ruins-of-alph-research-centers-roof-color-at-night-looks-wrong) ## Pic banks are offset by `PICS_FIX` @@ -791,3 +793,34 @@ Edit `GetForestTreeFrame`: + add a ret ``` + + +## Second rival battle's DVs are lower than the first + +The second rival battle has Pokémon whose DVs are actually *lower* than the DVs of the Pokémon from the first rival battle, which doesn't align with Silver's beliefs throughout the game. + +**Fix:** + +Edit [data/trainers/dvs.asm](https://github.com/pret/pokecrystal/blob/master/data/trainers/dvs.asm) to adjust the DVs of RIVAL2 to those of RIVAL1: + +```diff + dn 13, 13, 13, 13 ; RIVAL1 + ... +- dn 9, 8, 8, 8 ; RIVAL2 ++ dn 13, 13, 13, 13 ; RIVAL2 +``` + +## The Ruins of Alph research center's roof color at night looks wrong + +The Ruins of Alph research center's roof looks wonky during the night, making it look unprofessional. + +**Fix:** + +Edit [gfx/tilesets/roofs.pal](https://github.com/pret/pokecrystal/blob/master/gfx/tilesets/roofs.pal) to adjust Group 3's night palette to a suitable one (that of Pewter City's roofs in this instance): + +```diff +; group 3 (dungeons) + RGB 21,21,21, 11,11,11 ; morn/day +- RGB 21,21,21, 17,08,07 ; nite ++ RGB 09,09,11, 04,05,07 ; nite +```