pokehacks/pokecrystal-board
0
0
Fork 0
mirror of https://gitlab.com/xCrystal/pokecrystal-board.git synced 2024-11-16 11:27:33 -08:00
Code Issues Packages Projects Releases Wiki Activity
0af682d38a
pokecrystal-board/engine/menus/savemenu_copytilemapatonce.asm

78 lines
1.0 KiB
NASM
Raw Normal View History

Remove all address comments
2018-06-24 07:09:41 -07:00
SaveMenu_CopyTilemapAtOnce:
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh a, [hCGB]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
and a
jp z, WaitBGMap
; The following is a modified version of CopyTilemapAtOnce.
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh a, [hBGMapMode]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
push af
xor a
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh [hBGMapMode], a
ldh a, [hMapAnims]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
push af
xor a
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh [hMapAnims], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
.WaitLY:
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh a, [rLY]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
cp $60
jr c, .WaitLY
di
Lowercase v for VRAM addresses
2017-12-28 04:32:33 -08:00
ld a, BANK(vBGMap2)
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh [rVBK], a
Prefix wram labels with w, part 2.
2018-01-23 14:39:09 -08:00
hlcoord 0, 0, wAttrMap
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
call .CopyTilemapAtOnce
Lowercase v for VRAM addresses
2017-12-28 04:32:33 -08:00
ld a, BANK(vBGMap0)
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh [rVBK], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
hlcoord 0, 0
call .CopyTilemapAtOnce
.WaitLY2:
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh a, [rLY]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
cp $60
jr c, .WaitLY2
ei
pop af
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh [hMapAnims], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
pop af
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh [hBGMapMode], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
ret
Remove all address comments
2018-06-24 07:09:41 -07:00
.CopyTilemapAtOnce:
Remove HRAM label address comments
2018-08-25 11:39:24 -07:00
ld [hSPBuffer], sp
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
ld sp, hl
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh a, [hBGMapAddress + 1]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
ld h, a
ld l, 0
ld a, SCREEN_HEIGHT
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh [hTilesPerCycle], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
ld b, 1 << 1
Resolve #428: Use `HIGH(X)` and `LOW(X)` instead of `X / $100` and `X % $100` or `X >> 8` and `X & $ff`
2017-12-25 10:40:10 -08:00
ld c, LOW(rSTAT)
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
.loop
rept SCREEN_WIDTH / 2
pop de
.loop\@
ld a, [$ff00+c]
and b
jr nz, .loop\@
ld [hl], e
inc l
ld [hl], d
inc l
endr
ld de, BG_MAP_WIDTH - SCREEN_WIDTH
add hl, de
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh a, [hTilesPerCycle]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
dec a
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh [hTilesPerCycle], a
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
jr nz, .loop
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh a, [hSPBuffer]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
ld l, a
Use labels instead of constants for HRAM Use explicit ldh instruction to access HRAM locations, don't rely on optimizing ld
2018-08-25 11:28:22 -07:00
ldh a, [hSPBuffer + 1]
Remove all code from main.asm (some labeled INCBINs, like out-of-context graphics, are still present) engine/routines/ stores isolated out-of-context routines as individual files. It might be preferable later to append them to their related engine/ files in unique little SECTIONs, relying on the linkerscript to place them appropriately; or some other organization method. In the meantime, they're now easily findable apart from main.asm's other content.
2017-12-24 16:35:35 -08:00
ld h, a
ld sp, hl
ret
Reference in New Issue Copy Permalink