It is needed to avoid multiple definitions of AV_GET_CODEC_CONTEXT,
which is considered as an error with '-fno-common' which is default
since gcc-10.
Fixes: #511
BaseException is a python standard library exception class, so it's
not a great idea to redefine that name in our bindings. Renamed
to ExceptionBase, which is more in keeping with our class naming
system anyway.
- Reduced crazy-long line lengths by moving trailing comments to
previous line
- Added more openshot:: prefixing, which causes Doxygen to link to
the referenced object's documentation. (It doesn't always pick
up cross-class links, without the prefix.)
- The new ordering (with the frame rate AFTER width and height) doesn't
match the other signature, but it *is* consistent with the Timeline
constructor, and it just feels more natural
- Added overloaded-function notes to doxygen strings in FFmpegWriter.h
- Also added a warning about the argument order mismatch above
Add a new #define HAVE_HW_ACCEL, which is only set on FFmpeg 3.4+,
and use that to restrict the use of hw-accel features, leaving
IS_FFMPEG_3_2 to determine only whether code is compatible with
FFmpeg 3.2+.
- Parsing from string to Json::Value is now done by utility function
openshot::stringToJson() in Json.cpp, all SetJson() methods call it.
- Expand use of const member functions and args where appropriate.
- Use std::to_string() to format int/float values as strings.
- Correct mentions of nonexistent Json::JsonValue type in docstrings
A few headers contained #defines that were intended to work around
issues with the JUCE library headers, but those things are best
handled in other ways.
