openshot/libopenshot
0
0
Fork 0
mirror of https://github.com/OpenShot/libopenshot.git synced 2026-03-02 08:53:52 -08:00
Code Issues Packages Projects Releases Wiki Activity
3,137 Commits 9 Branches 27 Tags
comfy-ui
Commit Graph

513 Commits

Author SHA1 Message Date
Jonathan Thomas
3a50b9afc2 Paused and playback seek behavior now follows one rule: keep cache on in-range seeks, rebuild only on out-of-range seeks. 2026-03-01 22:49:31 -06:00
Jonathan Thomas
438c74f340 Adding new args to openshot-benchmark, so each test can be run separately - useful for quick optimization validation. 2026-03-01 21:25:27 -06:00
Jonathan Thomas
4387f8b394 - Timeline composition no longer mutates cached clip frames (fixes trails/ghosting). 
- Clip updates via ApplyJsonDiff now also clear clip cache (not just timeline/reader ranges).
- Added regressions for cache invalidation + no cached-frame mutation; kept paused preroll/cache-bar behavior intact.
 2026-03-01 14:19:27 -06:00
Jonathan Thomas
c1d4bf5bd8 Fix Profiles test temp-path helper after develop merge 2026-02-27 12:29:48 -06:00
Jonathan Thomas
b39cb385e8 Merge branch 'develop' into comfy-ui 2026-02-27 12:19:46 -06:00
Jonathan Thomas
ff22d416da - Playback updates no longer act like seeks. 
- Scrubbing inside cached area keeps cache.
- Scrubbing outside cached area clears cache immediately.
- Preroll now starts on seek commit (release), not during drag.
- Temporary debug logs were removed.
- Tests were added for these behaviors.
 2026-02-26 13:22:06 -06:00
Jonathan Thomas
00f82c239f More improvements to EffectBase support of masks (allowing all effects to use animated masks better). 
- Mask: Start/End (seconds) picks the exact part of a mask video to use.
  - Time Mode: Timeline follows project timing; Source FPS follows mask file timing.
  - Loop mode then defines playback behavior: Play Once, Repeat, or Ping-Pong.
 2026-02-24 23:41:32 -06:00
Jonathan Thomas
1a44a6582c Fixing mac unit test failures due to filesystem dependency again,ughh. 2026-02-24 13:05:39 -06:00
Jonathan Thomas
89350a0419 Setting has_static_image correctly when FFmpegReader opens image formats and a video_length == 1, so we have consistent behavior in OpenShot regardless of QtImageReader or FFmpegReader, when opening images. 2026-02-24 12:06:42 -06:00
Jonathan Thomas
fbd07d78d3 Integrating Mask effect with invert mask property and unit tests. This allows the Mask effect to invert the mask easily. 2026-02-23 21:09:27 -06:00
Jonathan Thomas
18b08fe7c6 Fixing unit test paths for mac builders, crashing due to filesystem import (I think) 2026-02-23 17:41:18 -06:00
Jonathan Thomas
7c65748187 Fixing unit test paths for windows builders 2026-02-23 17:25:23 -06:00
Jonathan Thomas
7efc48006a Modify all throw InvalidFile(...) callsites: each now has a distinct message string, and adding unit tests to verify this. 
So a crash line will now be more like:
  what(): FFmpegReader could not open media file. for file C:\...\TitleFileName%04d.png
  instead of only File could not be opened.
 2026-02-23 16:55:49 -06:00
Jonathan Thomas
1ad401c66d - Added a new common mask_reader feature at EffectBase, so all video effects can be mask-limited automatically (audio effects ignore it). 
- Added optional Mask Mode overrides for Blur, Saturation, Brightness, Hue, Pixelate, and Sharpen (Limit to Mask, Vary Strength).
- Kept unified mask property naming (mask_reader) with legacy JSON compatibility where needed.
- Added/updated unit tests for base mask behavior, per-effect mode behavior, and JSON round-trips.
- Fixed profile tests to write generated files into the build/test directory instead of the source examples/ folder.
 2026-02-23 00:00:33 -06:00
Jonathan Thomas
b7c37b84e4 - Fix FFmpegReader first-frame black regression by anchoring PTS offset to video start (and correcting video offset to use packet PTS), so AAC preroll/skip-samples no longer shifts frame 1. 
- Add examples/test_aac_preroll.mp4 fixture (small, deterministic AAC-preroll sample) for reproducing and testing the regression.
 2026-02-15 15:22:11 -06:00
Jonathan Thomas
c43092eaa5 Merge branch 'develop' into caching-protections 
# Conflicts:
#	src/Qt/VideoCacheThread.cpp
 2026-02-13 11:29:32 -06:00
Jonathan Thomas
fb41a3c479 • - Fix VideoCacheThread::isReady() so preroll readiness is clamped by frames actually available to the timeline boundary (end/start), preventing playback from stalling in PLAY near the end. 
- Add regression coverage in tests/VideoCacheThread.cpp (isReady: clamps preroll requirement at timeline boundaries) for forward-near-end and backward-near-start cases.
 2026-02-12 23:41:51 -06:00
Jonathan Thomas
d70e80eac4 Harden playback/cache path for malformed media and concurrent timeline updates 
- Invalidate timeline cache on ApplyJsonDiff() clip insert (remove affected frame range).
  - Add lock in Timeline::ClearAllCache() for safe concurrent access.
  - Make VideoCacheThread cross-thread state safe (atomics + seek-state mutex).
  - Lock CacheMemory::Contains() to avoid races.
  - Handle malformed audio streams in FFmpegReader by disabling invalid audio and continuing video-only.
  - Add FPS/timebase safety fallbacks in FFmpeg frame/PTS math.
  - Guard Frame::GetSamplesPerFrame() against invalid inputs.
  - Add/adjust regression tests for cache invalidation and invalid rate handling.
 2026-02-11 20:11:47 -06:00
Jonathan Thomas
43f9ed89ae VideoCacheThread: add directional preroll 
- start cache rebuilds with a preroll offset (settings-based)
- tighten isReady to require frames ahead/behind playhead add unit tests for preroll clamping and readiness
 2026-02-05 12:39:06 -06:00
Jonathan Thomas
16f791a55a Adding missing <sstream> includes for older compilers, and because it should be included anyway 2025-12-16 18:23:57 -06:00
Jonathan Thomas
2a82bed607 Adding upscaling for crop effect + resize property - so cropping into higher resolution content does not become blurry. 2025-12-15 23:34:48 -06:00
Jonathan Thomas
bd59e6bb37 Fix mixing licensing headers 2025-12-15 21:13:34 -06:00
Jonathan Thomas
1f06f03e9c Adding unit tests for image magic durations 2025-12-10 18:38:07 -06:00
Jonathan Thomas
94fab00048 Updating video_length and duration calculations to be consistent on image readers also (QtImageReader, ImageReader) 2025-12-08 18:33:23 -06:00
Jonathan Thomas
eea55982fd FFmpegReader: add duration strategy modes and unify duration/frame calculations. This is a potentially breaking change, where we ensure all durations and video_length calculations coming from FFmpegReader are now fully consistent - even if we must slightly adjust a duration from the video or audio stream. This keeps the 2 attributes identical in meaning (video_length X FPS == duration, no exceptions). Unknown durations are no longer -1 video_length but 0, and 0 duration. 2025-12-08 17:07:21 -06:00