openshot/libopenshot
0
0
Fork 0
mirror of https://github.com/OpenShot/libopenshot.git synced 2026-03-02 08:53:52 -08:00
Code Issues Packages Projects Releases Wiki Activity

Implement the use of CRF instead od kB/s or MB/s for some formats:

Browse Source 
VP8, VP9, h264, h265
0 crf with VP9 is lossless
0 crf with VP8, h264, h265 should be lossless
This commit is contained in:
eisneinechse
2018-09-16 18:14:31 -07:00
parent 08c7f88376
commit df9d1a5717
1 changed files with 27 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/FFmpegWriter.cpp
View File

@@ -241,7 +241,9 @@ void FFmpegWriter::SetVideoOptions(bool has_video, string codec, Fraction fps, i
info.pixel_ratio.num = pixel_ratio.num;
info.pixel_ratio.den = pixel_ratio.den;
}
if (bit_rate >= 1000)
if (bit_rate >= 1000) // bit_rate is the bitrate in b/s
info.video_bit_rate = bit_rate;
if ((bit_rate > 0) && (bit_rate <=63)) // bit_rate is the crf value
info.video_bit_rate = bit_rate;
info.interlaced_frame = interlaced;
@@ -1040,7 +1042,30 @@ AVStream* FFmpegWriter::add_video_stream()
#endif
/* Init video encoder options */
c->bit_rate = info.video_bit_rate;
if (info.video_bit_rate > 1000) {
c->bit_rate = info.video_bit_rate;
}
#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(55, 39, 101)
else {
switch (c->codec_id) {
case AV_CODEC_ID_VP8 :
av_opt_set_int(c->priv_data, "crf", min(info.video_bit_rate,63), 0);
break;
case AV_CODEC_ID_VP9 :
av_opt_set_int(c->priv_data, "crf", min(info.video_bit_rate,63), 0);
if (info.video_bit_rate == 0) {
av_opt_set_int(c->priv_data, "lossless", 1, 0);
}
break;
case AV_CODEC_ID_H264 :
av_opt_set_int(c->priv_data, "crf", min(info.video_bit_rate,51), 0);
break;
case AV_CODEC_ID_H265 :
av_opt_set_int(c->priv_data, "crf", min(info.video_bit_rate,51), 0);
break;
}
}
#endif
//TODO: Implement variable bitrate feature (which actually works). This implementation throws
//invalid bitrate errors and rc buffer underflow errors, etc...