From 8f77a78c6fc169e8b5eaae56ee2e4aa0d59f606b Mon Sep 17 00:00:00 2001
From: "FeRD (Frank Dana)" <ferdnyc@gmail.com>
Date: Mon, 4 Nov 2019 04:13:44 -0500
Subject: [PATCH] CMake: Update linking, no more REQUIRED_LIBRARIES

- All linking is done after target creation
- Use BOOL generator expressions for conditional linking
---
 src/CMakeLists.txt | 36 ++++++++++--------------------------
 1 file changed, 10 insertions(+), 26 deletions(-)

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 3c16d223..f652f883 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -367,34 +367,18 @@ endif()
 
 
 ###############  LINK LIBRARY  #################
-SET ( REQUIRED_LIBRARIES
-		${LIBOPENSHOT_AUDIO_LIBRARIES}
-		${PROFILER}
-		)
+# Link remaining dependency libraries
+target_link_libraries(openshot PUBLIC
+	${LIBOPENSHOT_AUDIO_LIBRARIES}
+	${PROFILER}
+	$<$<BOOL:ImageMagick_FOUND>:${ImageMagick_LIBRARIES}>
+	$<$<BOOL:RESVG_FOUND>:${RESVG_LIBRARIES}>
+	$<$<BOOL:BLACKMAGIC_FOUND>:${BLACKMAGIC_LIBRARY_DIR}>)
 
-IF (RESVG_FOUND)
-	list(APPEND REQUIRED_LIBRARIES ${RESVG_LIBRARIES})
-ENDIF(RESVG_FOUND)
-
-
-IF (ImageMagick_FOUND)
-  list(APPEND REQUIRED_LIBRARIES ${ImageMagick_LIBRARIES})
-ENDIF (ImageMagick_FOUND)
-
-IF (BLACKMAGIC_FOUND)
-	list(APPEND REQUIRED_LIBRARIES ${BLACKMAGIC_LIBRARY_DIR})
-ENDIF (BLACKMAGIC_FOUND)
-
-IF (WIN32)
+if(WIN32)
 	# Required for exception handling on Windows
-	list(APPEND REQUIRED_LIBRARIES "imagehlp" "dbghelp" )
-ENDIF(WIN32)
-
-# Link all referenced libraries
-target_link_libraries(openshot PUBLIC ${REQUIRED_LIBRARIES})
-
-# Pick up parameters from OpenMP target and propagate
-target_link_libraries(openshot PUBLIC OpenMP::OpenMP_CXX)
+	target_link_libraries(openshot PUBLIC "imagehlp" "dbghelp" )
+endif()
 
 ############### CLI EXECUTABLES ################
 # Create test executable