From 893a7c4240ec7adbb0dbba253469948bf05201bb Mon Sep 17 00:00:00 2001 From: "FeRD (Frank Dana)" Date: Fri, 9 Apr 2021 04:49:43 -0400 Subject: [PATCH] Fix test memory leaks --- tests/DummyReader.cpp | 2 ++ tests/FrameMapper.cpp | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/DummyReader.cpp b/tests/DummyReader.cpp index e54e889c..fc832624 100644 --- a/tests/DummyReader.cpp +++ b/tests/DummyReader.cpp @@ -110,6 +110,8 @@ TEST_CASE( "Fake_Frame", "[libopenshot][dummyreader]" ) { // Add test frame to dummy reader cache.Add(f); + + delete[] audio_buffer; } // Create a default fraction (should be 1/1) diff --git a/tests/FrameMapper.cpp b/tests/FrameMapper.cpp index 34ba233a..68b88aa3 100644 --- a/tests/FrameMapper.cpp +++ b/tests/FrameMapper.cpp @@ -238,7 +238,7 @@ TEST_CASE( "resample_audio_mapper", "[libopenshot][framemapper]" ) { // Create blank frame (with specific frame #, samples, and channels) // Sample count should be 44100 / 30 fps = 1470 samples per frame int sample_count = 1470; - std::shared_ptr f(new openshot::Frame(frame_number, sample_count, 2)); + auto f = std::make_shared(frame_number, sample_count, 2); // Create test samples with sin wave (predictable values) float *audio_buffer = new float[sample_count * 2]; @@ -256,6 +256,8 @@ TEST_CASE( "resample_audio_mapper", "[libopenshot][framemapper]" ) { // Add test frame to dummy reader cache.Add(f); + + delete[] audio_buffer; } // Create a default fraction (should be 1/1) @@ -377,7 +379,7 @@ TEST_CASE( "redistribute_samples_per_frame", "[libopenshot][framemapper]" ) { // Create blank frame (with specific frame #, samples, and channels) // Sample count should be 44100 / 30 fps = 1470 samples per frame int sample_count = 1470; - std::shared_ptr f(new openshot::Frame(frame_number, sample_count, 2)); + auto f = std::make_shared(frame_number, sample_count, 2); // Create test samples with incrementing value float *audio_buffer = new float[sample_count]; @@ -394,6 +396,8 @@ TEST_CASE( "redistribute_samples_per_frame", "[libopenshot][framemapper]" ) { // Add test frame to dummy reader cache.Add(f); + + delete[] audio_buffer; } // Create a default fraction (should be 1/1)