Merge pull request #265 from ferdnyc/catch-by-reference

Exceptions: catch-by-reference and other cleanup
This commit is contained in:
Jonathan Thomas
2019-07-29 16:27:40 -05:00
committed by GitHub
35 changed files with 104 additions and 109 deletions

View File

@@ -120,7 +120,7 @@ Profile::Profile(string path) {
}
}
catch (exception e)
catch (const std::exception& e)
{
// Error parsing profile file
throw InvalidFile("Profile could not be found or loaded (or is invalid).", path);
@@ -184,7 +184,7 @@ void Profile::SetJson(string value) {
// Set all values that match
SetJsonValue(root);
}
catch (exception e)
catch (const std::exception& e)
{
// Error parsing JSON (or missing keys)
throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");