openshot/libopenshot
0
0
Fork 0
mirror of https://github.com/OpenShot/libopenshot.git synced 2026-03-02 08:53:52 -08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #265 from ferdnyc/catch-by-reference

Browse Source 
Exceptions: catch-by-reference and other cleanup
This commit is contained in:
Jonathan Thomas
2019-07-29 16:27:40 -05:00
committed by GitHub
parent f3354d997a 80765147b9
commit 5f331e24df
35 changed files with 104 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/ImageReader.cpp
View File

@@ -67,7 +67,7 @@ void ImageReader::Open()
image->backgroundColor(Magick::Color("none"));
MAGICK_IMAGE_ALPHA(image, true);
}
catch (Magick::Exception e) {
catch (const Magick::Exception& e) {
// raise exception
throw InvalidFile("File could not be opened.", path);
}
@@ -176,7 +176,7 @@ void ImageReader::SetJson(string value) {
// Set all values that match
SetJsonValue(root);
}
catch (exception e)
catch (const std::exception& e)
{
// Error parsing JSON (or missing keys)
throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");