Merge pull request #265 from ferdnyc/catch-by-reference

Exceptions: catch-by-reference and other cleanup
This commit is contained in:
Jonathan Thomas
2019-07-29 16:27:40 -05:00
committed by GitHub
35 changed files with 104 additions and 109 deletions

View File

@@ -123,7 +123,7 @@ void Clip::init_reader_rotation() {
try {
float rotate_metadata = strtof(reader->info.metadata["rotate"].c_str(), 0);
rotation = Keyframe(rotate_metadata);
} catch (exception e) {}
} catch (const std::exception& e) {}
}
else
// Default no rotation
@@ -811,7 +811,7 @@ void Clip::SetJson(string value) {
// Set all values that match
SetJsonValue(root);
}
catch (exception e)
catch (const std::exception& e)
{
// Error parsing JSON (or missing keys)
throw InvalidJSON("JSON is invalid (missing keys or invalid data types)", "");