From fea4f7eb188dbc540f6f019334bcdf50ab98140c Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Wed, 2 Aug 2023 08:42:31 +0200 Subject: [PATCH] dns/bind: safeguard this as well --- dns/bind/Makefile | 1 + .../src/opnsense/mvc/app/models/OPNsense/Bind/General.php | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/dns/bind/Makefile b/dns/bind/Makefile index e78625cad..f0efb8335 100644 --- a/dns/bind/Makefile +++ b/dns/bind/Makefile @@ -1,5 +1,6 @@ PLUGIN_NAME= bind PLUGIN_VERSION= 1.27 +PLUGIN_REVISION= 1 PLUGIN_COMMENT= BIND domain name service PLUGIN_DEPENDS= bind918 PLUGIN_MAINTAINER= m.muenz@gmail.com diff --git a/dns/bind/src/opnsense/mvc/app/models/OPNsense/Bind/General.php b/dns/bind/src/opnsense/mvc/app/models/OPNsense/Bind/General.php index b2cff5a82..3f73c40c4 100644 --- a/dns/bind/src/opnsense/mvc/app/models/OPNsense/Bind/General.php +++ b/dns/bind/src/opnsense/mvc/app/models/OPNsense/Bind/General.php @@ -47,6 +47,10 @@ class General extends BaseModel if (empty($service['dns_ports'])) { continue; } + if (!is_array($service['dns_ports'])) { + syslog(LOG_ERR, sprintf('Service %s (%s) reported a faulty "dns_ports" entry.', $service['description'], $service['name'])); + continue; + } if ($service['name'] != 'named' && in_array((string)$this->port, $service['dns_ports'])) { $messages->appendMessage(new Message( sprintf(gettext('%s is currently using this port.'), $service['description']),