From b92c2e631f663fafc54d279c1623266137c8c483 Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Fri, 14 Nov 2025 20:30:30 +0100 Subject: [PATCH] dns/rfc2136: second iteration using mwexecfb(), no functional changes --- dns/rfc2136/src/etc/inc/plugins.inc.d/rfc2136.inc | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/dns/rfc2136/src/etc/inc/plugins.inc.d/rfc2136.inc b/dns/rfc2136/src/etc/inc/plugins.inc.d/rfc2136.inc index 55c84297a..1e802cece 100644 --- a/dns/rfc2136/src/etc/inc/plugins.inc.d/rfc2136.inc +++ b/dns/rfc2136/src/etc/inc/plugins.inc.d/rfc2136.inc @@ -198,15 +198,16 @@ function rfc2136_configure_do($verbose = false, $int = null, $updatehost = '', $ $upinst .= "\n"; /* mind that trailing newline! */ if ($need_update) { - $cmds = "/var/etc/nsupdatecmds{$i}"; - file_safe($cmds, $upinst); - $args = []; - $args[] = exec_safe('-k %s', $keyfile); + file_safe("/var/etc/nsupdatecmds{$i}", $upinst); + + $frmt = ['/var/etc/nsupdatecmds%s -k %s']; + $args = [$i, $keyfile]; + if (isset($dnsupdate['usetcp'])) { - $args[] = '-v'; + $frmt[] = '-v'; } - $args[] = exec_safe('%s', $cmds); - mwexecf_bg('/usr/local/bin/nsupdate ' . join(' ', $args)); + + mwexecfb($frmt, $args); } }