From 8f7e89fc1880dc66a8ddc8d68b3fc741164a9eac Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Mon, 14 May 2018 05:17:31 +0000 Subject: [PATCH] net-mgmt/snmp: "fix" the broken listening logic PR: https://forum.opnsense.org/index.php?topic=8624.0 --- net-mgmt/snmp/Makefile | 2 +- net-mgmt/snmp/src/etc/inc/plugins.inc.d/bsnmpd.inc | 11 +++++++---- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/net-mgmt/snmp/Makefile b/net-mgmt/snmp/Makefile index 14d288af8..48d0e137d 100644 --- a/net-mgmt/snmp/Makefile +++ b/net-mgmt/snmp/Makefile @@ -1,5 +1,5 @@ PLUGIN_NAME= snmp -PLUGIN_VERSION= 1.2 +PLUGIN_VERSION= 1.3 PLUGIN_DEPENDS= bsnmp-regex bsnmp-ucd PLUGIN_COMMENT= SNMP Server via bsnmpd PLUGIN_MAINTAINER= franco@opnsense.org diff --git a/net-mgmt/snmp/src/etc/inc/plugins.inc.d/bsnmpd.inc b/net-mgmt/snmp/src/etc/inc/plugins.inc.d/bsnmpd.inc index 382204795..b0c5885b9 100644 --- a/net-mgmt/snmp/src/etc/inc/plugins.inc.d/bsnmpd.inc +++ b/net-mgmt/snmp/src/etc/inc/plugins.inc.d/bsnmpd.inc @@ -1,7 +1,7 @@ + * Copyright (C) 2014-2018 Franco Fichtner * Copyright (C) 2010 Ermal Luçi * Copyright (C) 2005-2006 Colin Smith * Copyright (C) 2003-2004 Manuel Kasper @@ -126,13 +126,16 @@ begemotSnmpdCommunityDisable = 1 EOD; - $bind_to_ip = "0.0.0.0"; - if (isset($config['snmpd']['bindip'])) { + $bind_to_ip = '0.0.0.0'; + if (!empty($config['snmpd']['bindip'])) { if (is_ipaddr($config['snmpd']['bindip'])) { $bind_to_ip = $config['snmpd']['bindip']; } else { $if = get_real_interface($config['snmpd']['bindip']); - $bind_to_ip = find_interface_ip($if); + $bind_to_ip_maybe = find_interface_ip($if); + if (is_ipaddr($bind_to_ip_maybe)) { + $bind_to_ip = $bind_to_ip_maybe; + } } }