From d4be1e7732697c64f80eee48c89c08448ae32b83 Mon Sep 17 00:00:00 2001
From: Frank Wall <fw@moov.de>
Date: Wed, 6 Oct 2021 23:11:47 +0200
Subject: [PATCH 1/5] net/haproxy: remove default values, refs #2560

---
 .../opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.xml   | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/net/haproxy/src/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.xml b/net/haproxy/src/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.xml
index bf8cc8895..15b3ce18e 100644
--- a/net/haproxy/src/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.xml
+++ b/net/haproxy/src/opnsense/mvc/app/models/OPNsense/HAProxy/HAProxy.xml
@@ -2755,44 +2755,37 @@
                     <Required>N</Required>
                 </timeout_retry>
                 <accepted_payload_size type="IntegerField">
-                    <default>512</default>
                     <MinimumValue>0</MinimumValue>
                     <MaximumValue>8192</MaximumValue>
                     <ValidationMessage>Should be a number between 0 and 8192</ValidationMessage>
                     <Required>N</Required>
                 </accepted_payload_size>
                 <hold_valid type="TextField">
-                    <default>10s</default>
                     <mask>/^([0-9]{1,8}(?:us|ms|s|m|h|d)?)/u</mask>
                     <ValidationMessage>Should be a number between 1 and 8 characters, optionally followed by either "d", "h", "m", "s", "ms" or "us".</ValidationMessage>
                     <Required>N</Required>
                 </hold_valid>
                 <hold_obsolete type="TextField">
-                    <default>10s</default>
                     <mask>/^([0-9]{1,8}(?:us|ms|s|m|h|d)?)/u</mask>
                     <ValidationMessage>Should be a number between 1 and 8 characters, optionally followed by either "d", "h", "m", "s", "ms" or "us".</ValidationMessage>
                     <Required>N</Required>
                 </hold_obsolete>
                 <hold_refused type="TextField">
-                    <default>10s</default>
                     <mask>/^([0-9]{1,8}(?:us|ms|s|m|h|d)?)/u</mask>
                     <ValidationMessage>Should be a number between 1 and 8 characters, optionally followed by either "d", "h", "m", "s", "ms" or "us".</ValidationMessage>
                     <Required>N</Required>
                 </hold_refused>
                 <hold_nx type="TextField">
-                    <default>10s</default>
                     <mask>/^([0-9]{1,8}(?:us|ms|s|m|h|d)?)/u</mask>
                     <ValidationMessage>Should be a number between 1 and 8 characters, optionally followed by either "d", "h", "m", "s", "ms" or "us".</ValidationMessage>
                     <Required>N</Required>
                 </hold_nx>
                 <hold_timeout type="TextField">
-                    <default>10s</default>
                     <mask>/^([0-9]{1,8}(?:us|ms|s|m|h|d)?)/u</mask>
                     <ValidationMessage>Should be a number between 1 and 8 characters, optionally followed by either "d", "h", "m", "s", "ms" or "us".</ValidationMessage>
                     <Required>N</Required>
                 </hold_timeout>
                 <hold_other type="TextField">
-                    <default>10s</default>
                     <mask>/^([0-9]{1,8}(?:us|ms|s|m|h|d)?)/u</mask>
                     <ValidationMessage>Should be a number between 1 and 8 characters, optionally followed by either "d", "h", "m", "s", "ms" or "us".</ValidationMessage>
                     <Required>N</Required>

From 04fa2aa60abac0adb59f2202df1fb96fd7d951df Mon Sep 17 00:00:00 2001
From: Frank Wall <fw@moov.de>
Date: Wed, 6 Oct 2021 23:13:26 +0200
Subject: [PATCH 2/5] net/haproxy: update changelog

---
 net/haproxy/pkg-descr | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/net/haproxy/pkg-descr b/net/haproxy/pkg-descr
index fce3447a0..c4e4ba901 100644
--- a/net/haproxy/pkg-descr
+++ b/net/haproxy/pkg-descr
@@ -6,6 +6,11 @@ very high loads while needing persistence or Layer7 processing.
 Plugin Changelog
 ================
 
+3.6
+
+Added:
+* add support for advanced resolver properties (#2330)
+
 3.5
 
 Fixed:

From 0c80a6a34bbaa129afb42471f40276d6aa9189c8 Mon Sep 17 00:00:00 2001
From: Frank Wall <fw@moov.de>
Date: Wed, 6 Oct 2021 23:13:41 +0200
Subject: [PATCH 3/5] net/haproxy: bump version

---
 net/haproxy/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/haproxy/Makefile b/net/haproxy/Makefile
index be6664fc8..96f7ef082 100644
--- a/net/haproxy/Makefile
+++ b/net/haproxy/Makefile
@@ -1,5 +1,5 @@
 PLUGIN_NAME=		haproxy
-PLUGIN_VERSION=		3.5
+PLUGIN_VERSION=		3.6
 PLUGIN_COMMENT=		Reliable, high performance TCP/HTTP load balancer
 PLUGIN_DEPENDS=		haproxy22
 PLUGIN_MAINTAINER=	opnsense@moov.de

From d3457c26201c0af570e7209a36e7ccf0858b7d0b Mon Sep 17 00:00:00 2001
From: Frank Wall <fw@moov.de>
Date: Wed, 6 Oct 2021 23:29:22 +0200
Subject: [PATCH 4/5] net/haproxy: fix label, refs #2560

---
 .../app/controllers/OPNsense/HAProxy/forms/dialogResolver.xml   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/forms/dialogResolver.xml b/net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/forms/dialogResolver.xml
index d4fb81e86..a769aead4 100644
--- a/net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/forms/dialogResolver.xml
+++ b/net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/forms/dialogResolver.xml
@@ -88,7 +88,7 @@
     </field>
     <field>
         <id>resolver.hold_timeout</id>
-        <label>Valid hold time</label>
+        <label>Timeout hold time</label>
         <type>text</type>
         <help><![CDATA[When a DNS resolve request times out haproxy will not retry until [hold timeout] elapses. Default "30s"]]></help>
         <advanced>true</advanced>

From 962a63310f60661dbf2b7a380e5f8e6e256a9712 Mon Sep 17 00:00:00 2001
From: Frank Wall <fw@moov.de>
Date: Thu, 7 Oct 2021 23:40:08 +0200
Subject: [PATCH 5/5] net/haproxy: deploy haproxy.conf if it does not exist,
 fixes #2474

---
 net/haproxy/pkg-descr                             | 6 ++++++
 net/haproxy/src/etc/rc.syshook.d/start/50-haproxy | 7 +++++++
 2 files changed, 13 insertions(+)
 create mode 100755 net/haproxy/src/etc/rc.syshook.d/start/50-haproxy

diff --git a/net/haproxy/pkg-descr b/net/haproxy/pkg-descr
index c4e4ba901..0b23647bf 100644
--- a/net/haproxy/pkg-descr
+++ b/net/haproxy/pkg-descr
@@ -11,6 +11,12 @@ Plugin Changelog
 Added:
 * add support for advanced resolver properties (#2330)
 
+Fixed:
+* no haproxy.conf after restoring a config backup (#2474)
+
+Changed:
+* deploy haproxy.conf if it does not exist (#2474)
+
 3.5
 
 Fixed:
diff --git a/net/haproxy/src/etc/rc.syshook.d/start/50-haproxy b/net/haproxy/src/etc/rc.syshook.d/start/50-haproxy
new file mode 100755
index 000000000..09c0e0ef1
--- /dev/null
+++ b/net/haproxy/src/etc/rc.syshook.d/start/50-haproxy
@@ -0,0 +1,7 @@
+#!/bin/sh
+
+# fallback if no config file exists (i.e. after config backup restore)
+if [ ! -e /usr/local/etc/haproxy.conf -a -e /usr/local/etc/haproxy.conf.staging ]; then
+    cp /usr/local/etc/haproxy.conf.staging /usr/local/etc/haproxy.conf
+    /usr/local/etc/rc.d/haproxy start
+fi