diff --git a/dns/ddclient/Makefile b/dns/ddclient/Makefile index 9bb1936a3..fcf1873f7 100644 --- a/dns/ddclient/Makefile +++ b/dns/ddclient/Makefile @@ -1,6 +1,6 @@ PLUGIN_NAME= ddclient PLUGIN_VERSION= 1.21 -PLUGIN_REVISION= 1 +PLUGIN_REVISION= 2 PLUGIN_DEPENDS= ddclient py${PLUGIN_PYTHON}-boto3 PLUGIN_COMMENT= Dynamic DNS client PLUGIN_MAINTAINER= ad@opnsense.org diff --git a/dns/ddclient/src/etc/inc/plugins.inc.d/ddclient.inc b/dns/ddclient/src/etc/inc/plugins.inc.d/ddclient.inc index 8e087a38e..2a45595e5 100644 --- a/dns/ddclient/src/etc/inc/plugins.inc.d/ddclient.inc +++ b/dns/ddclient/src/etc/inc/plugins.inc.d/ddclient.inc @@ -30,9 +30,13 @@ function ddclient_services() { $services = []; + $cnf = \OPNsense\Core\Config::getInstance()->object(); + $is_enabled = false; + if ($cnf->OPNsense && $cnf->OPNsense->DynDNS && $cnf->OPNsense->DynDNS->general){ + $is_enabled = $cnf->OPNsense->DynDNS->general->enabled == '1'; + } - $mdl = new \OPNsense\DynDNS\DynDNS(); - if ($mdl->general->enabled == '1') { + if ($is_enabled) { $service = [ 'description' => gettext('ddclient'), 'configd' => [ @@ -42,7 +46,7 @@ function ddclient_services() ], 'name' => 'ddclient', ]; - $service['pidfile'] = (string)$mdl->general->backend != 'opnsense' ? '/var/run/ddclient.pid' : '/var/run/ddclient_opn.pid'; + $service['pidfile'] = $cnf->OPNsense->DynDNS->general->backend != 'opnsense' ? '/var/run/ddclient.pid' : '/var/run/ddclient_opn.pid'; $services[] = $service; }