diff --git a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml index 890240560..ad1d54aae 100644 --- a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml +++ b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml @@ -126,9 +126,11 @@ validation.dns_sleep - + text - The time in seconds to wait for all the TXT records to take effect after adding them to the DNS API. Defaults to 120 seconds. + The time in seconds to wait for all the TXT records to take effect after adding them to the DNS API. Defaults to 120 seconds. + For public DNS validation each 10 seconds up to 20 minutes, instead of fixed DNS sleep time set value to 0. + 0 for public DNS check or 1-84600s diff --git a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/Base.php b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/Base.php index c0289569e..b516343d6 100644 --- a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/Base.php +++ b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidation/Base.php @@ -80,7 +80,9 @@ abstract class Base extends \OPNsense\AcmeClient\LeCommon switch ((string)$this->config->method) { case 'dns01': $this->acme_args[] = LeUtils::execSafe('--dns %s', (string)$this->config->dns_service); - $this->acme_args[] = LeUtils::execSafe('--dnssleep %s', (string)$this->config->dns_sleep); + if (! (string)$this->config->dns_sleep == '0') { + $this->acme_args[] = LeUtils::execSafe('--dnssleep %s', (string)$this->config->dns_sleep); + } break; case 'http01': $this->acme_args[] = '--webroot ' . self::ACME_WEBROOT; diff --git a/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml b/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml index 5fd41ff30..4222cc253 100644 --- a/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml +++ b/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml @@ -505,10 +505,10 @@ - 1 + 0 84600 120 - Please specify a value between 1 and 84600. + Please specify a value between 0 and 84600 seconds. Y