From 5ec04f9e54b6e4413983a50b561943ee122ae410 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Fri, 13 Mar 2020 16:54:23 +0100
Subject: [PATCH] os-firewall: fix typo in
 https://github.com/opnsense/plugins/issues/1720 leading to missing
 destination ports

---
 .../app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/firewall/src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php b/net/firewall/src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php
index e49d452d6..70996125e 100644
--- a/net/firewall/src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php
+++ b/net/firewall/src/opnsense/mvc/app/models/OPNsense/Firewall/FieldTypes/FilterRuleField.php
@@ -80,7 +80,7 @@ class FilterRuleContainerField extends ContainerField
             if (!empty((string)$this->destination_not)) {
                 $result['destination']['not'] = true;
             }
-            if (!empty((string)$this->source_port)) {
+            if (!empty((string)$this->destination_port)) {
                 $result['destination']['port'] = (string)$this->destination_port;
             }
         }