From 5e1210bb0df8be4855024d4653630c46200f95a5 Mon Sep 17 00:00:00 2001 From: Frank Wall Date: Sat, 31 Jul 2021 14:53:20 +0200 Subject: [PATCH] security/acme-client: rename to "ACME Client", refs #2361 --- security/acme-client/Makefile | 2 +- security/acme-client/pkg-descr | 1 + .../src/etc/inc/plugins.inc.d/acmeclient.inc | 4 ++-- .../OPNsense/AcmeClient/Api/SettingsController.php | 10 +++++----- .../OPNsense/AcmeClient/forms/dialogCertificate.xml | 8 ++++---- .../OPNsense/AcmeClient/forms/dialogValidation.xml | 6 +++--- .../OPNsense/AcmeClient/forms/settings.xml | 4 ++-- .../app/library/OPNsense/AcmeClient/LeAccount.php | 4 ++-- .../OPNsense/AcmeClient/LeAutomationInterface.php | 4 ++-- .../library/OPNsense/AcmeClient/LeCertificate.php | 12 ++++++------ .../mvc/app/library/OPNsense/AcmeClient/LeCommon.php | 2 +- .../OPNsense/AcmeClient/LeValidationInterface.php | 4 ++-- .../mvc/app/models/OPNsense/AcmeClient/ACL/ACL.xml | 6 +++--- .../app/models/OPNsense/AcmeClient/AcmeClient.xml | 2 +- .../mvc/app/models/OPNsense/AcmeClient/Menu/Menu.xml | 5 ++--- .../mvc/app/views/OPNsense/AcmeClient/accounts.volt | 4 ++-- .../opnsense/scripts/OPNsense/AcmeClient/lecert.php | 8 ++++---- .../service/conf/actions.d/actions_acmeclient.conf | 2 +- .../OPNsense/AcmeClient/lighttpd-acme-challenge.conf | 2 +- 19 files changed, 45 insertions(+), 45 deletions(-) diff --git a/security/acme-client/Makefile b/security/acme-client/Makefile index 97ee0b6ea..de8023fa3 100644 --- a/security/acme-client/Makefile +++ b/security/acme-client/Makefile @@ -1,6 +1,6 @@ PLUGIN_NAME= acme-client PLUGIN_VERSION= 2.6 -PLUGIN_COMMENT= Let's Encrypt client +PLUGIN_COMMENT= ACME Client PLUGIN_MAINTAINER= opnsense@moov.de PLUGIN_DEPENDS= acme.sh py${PLUGIN_PYTHON}-dns-lexicon diff --git a/security/acme-client/pkg-descr b/security/acme-client/pkg-descr index b6dc6e05e..101894d32 100644 --- a/security/acme-client/pkg-descr +++ b/security/acme-client/pkg-descr @@ -14,6 +14,7 @@ Added: * add support for new ACME CA's: buypass, buypass_test, sslcom, zerossl (#2361) Changed: +* rename plugin from "Let's Encrypt client" to "ACME Client" (#2361) * rename "Let's Encrypt Environment" to "ACME CA" (#2361) * preserve old LE accounts/certs by adding a compatibility layer (#2361) diff --git a/security/acme-client/src/etc/inc/plugins.inc.d/acmeclient.inc b/security/acme-client/src/etc/inc/plugins.inc.d/acmeclient.inc index 801a1fb07..92b8881e2 100644 --- a/security/acme-client/src/etc/inc/plugins.inc.d/acmeclient.inc +++ b/security/acme-client/src/etc/inc/plugins.inc.d/acmeclient.inc @@ -1,7 +1,7 @@ gettext('Let\'s Encrypt client'), + 'description' => gettext('ACME client'), 'pidfile' => '/var/run/lighttpd-acme-challenge.pid', 'configd' => array( 'restart' => array('acme-http-challenge restart'), diff --git a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php index 3dee7cfb2..c8bef9805 100644 --- a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php +++ b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/Api/SettingsController.php @@ -1,7 +1,7 @@ newAcl( "find_acme_challenge", - "Added by Let's Encrypt plugin", + "Added by ACME Client plugin", "path_beg", "0", array("path_beg" => "/.well-known/acme-challenge/") @@ -273,7 +273,7 @@ class SettingsController extends ApiMutableModelControllerBase $backend_uuid = $mdlHAProxy->newBackend( "1", "acme_challenge_backend", - "Added by Let's Encrypt plugin", + "Added by ACME Client plugin", "http", "source", "", @@ -283,7 +283,7 @@ class SettingsController extends ApiMutableModelControllerBase // Add a new HAProxy action $action_uuid = $mdlHAProxy->newAction( "redirect_acme_challenges", - "Added by Let's Encrypt plugin", + "Added by ACME Client plugin", "if", "", "and", @@ -298,7 +298,7 @@ class SettingsController extends ApiMutableModelControllerBase // Add a new HAProxy server $server_uuid = $mdlHAProxy->newServer( "acme_challenge_host", - "Added by Let's Encrypt plugin", + "Added by ACME Client plugin", "127.0.0.1", $acme_port, "active", diff --git a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogCertificate.xml b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogCertificate.xml index ee0eb8daf..a78b2f051 100644 --- a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogCertificate.xml +++ b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogCertificate.xml @@ -27,24 +27,24 @@ select_multiple true -
NOTE:You need to forcefully re-issue the certificate if you change "Alt Names" after the certificate was signed by the Let's Encrypt Authority! Use the "issue" button in the Commands column in this case.
]]>
+
NOTE:You need to forcefully re-issue the certificate if you change "Alt Names" after the certificate was signed by the ACME CA! Use the "issue" button in the Commands column in this case.
]]>
Enter FQDN here. Finish with TAB. - + header certificate.account dropdown - + certificate.validationMethod dropdown - + certificate.autoRenewal diff --git a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml index 527601cfd..4faa6b778 100644 --- a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml +++ b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/dialogValidation.xml @@ -21,7 +21,7 @@ validation.method dropdown - Set the Let's Encrypt challenge type. You'll have to add configuration for the selected challenge type below. + Set the ACME challenge type. You'll have to add configuration for the selected challenge type below. @@ -48,7 +48,7 @@ validation.http_opn_interface dropdown -
NOTE:This will ONLY work if the official IP addresses are LOCALLY configured on your OPNsense firewall.
]]>
+
NOTE:This will ONLY work if the official IP addresses are LOCALLY configured on your OPNsense firewall.
]]>
validation.http_opn_ipaddresses @@ -56,7 +56,7 @@ select_multiple true -
NOTE:This will ONLY work if the official IP addresses are LOCALLY configured on your OPNsense firewall.
]]>
+
NOTE:This will ONLY work if the official IP addresses are LOCALLY configured on your OPNsense firewall.
]]>
Enter IP addresses here. Finish each with TAB.
diff --git a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/settings.xml b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/settings.xml index b72241e64..e5cea7414 100644 --- a/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/settings.xml +++ b/security/acme-client/src/opnsense/mvc/app/controllers/OPNsense/AcmeClient/forms/settings.xml @@ -3,7 +3,7 @@ acmeclient.settings.enabled checkbox - + acmeclient.settings.autoRenewal @@ -33,7 +33,7 @@ acmeclient.settings.challengePort text - + true diff --git a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAccount.php b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAccount.php index 5aa9e2ab2..ad172033c 100644 --- a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAccount.php +++ b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAccount.php @@ -31,7 +31,7 @@ namespace OPNsense\AcmeClient; use OPNsense\Core\Config; /** - * Manage Let's Encrypt accounts with acme.sh + * Manage ACME CA accounts with acme.sh * @package OPNsense\AcmeClient */ class LeAccount extends LeCommon @@ -192,7 +192,7 @@ class LeAccount extends LeCommon } /** - * register account with Let's Encrypt + * register account with configured ACME CA * @return bool */ public function register() diff --git a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAutomationInterface.php b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAutomationInterface.php index 707b65aff..30607fd80 100644 --- a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAutomationInterface.php +++ b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAutomationInterface.php @@ -1,7 +1,7 @@ object()->addChild('ca'); foreach (array_keys($ca) as $cacfg) { $newca->addChild($cacfg, (string)$ca[$cacfg]); @@ -251,7 +251,7 @@ class LeCertificate extends LeCommon // Collect required cert information $cert_cn = LeUtils::local_cert_get_cn($cert_content, false); - $cert['descr'] = (string)$cert_cn . ' (Let\'s Encrypt)'; + $cert['descr'] = (string)$cert_cn . ' (ACME Client)'; $cert['refid'] = $cert_refid; // Prepare certificate for import @@ -277,7 +277,7 @@ class LeCertificate extends LeCommon $newcert->addChild($certcfg, (string)$cert[$certcfg]); } } - LeUtils::log("${import_log_message} Let's Encrypt X.509 certificate: ${cert_cn}"); + LeUtils::log("${import_log_message} ACME X.509 certificate: ${cert_cn}"); /** * Step 3: update configuration @@ -300,7 +300,7 @@ class LeCertificate extends LeCommon } /** - * check if certificate is already issued by Let's Encrypt + * check if certificate is already issued by ACME CA * @return bool */ public function isIssued() diff --git a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCommon.php b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCommon.php index 422a82508..f8d765bd3 100644 --- a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCommon.php +++ b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCommon.php @@ -32,7 +32,7 @@ use OPNsense\Core\Config; use OPNsense\AcmeClient\LeUtils; /** - * Common constants and functions for all Let's Encrypt classes + * Common constants and functions for all ACME classes * @package OPNsense\AcmeClient */ abstract class LeCommon diff --git a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidationInterface.php b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidationInterface.php index 903486ffa..86c6be451 100644 --- a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidationInterface.php +++ b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeValidationInterface.php @@ -1,7 +1,7 @@ - - Services: Let's Encrypt + + Services: ACME Client ui/acmeclient/* api/acmeclient/* - + diff --git a/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml b/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml index a105ce598..5f0c4fd6c 100644 --- a/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml +++ b/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/AcmeClient.xml @@ -1,7 +1,7 @@ //OPNsense/AcmeClient 3.0.0 - A secure Let's Encrypt plugin + A secure ACME Client plugin diff --git a/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/Menu/Menu.xml b/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/Menu/Menu.xml index 33a92cfb5..07b758fd0 100644 --- a/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/Menu/Menu.xml +++ b/security/acme-client/src/opnsense/mvc/app/models/OPNsense/AcmeClient/Menu/Menu.xml @@ -1,7 +1,6 @@ - - + @@ -13,6 +12,6 @@ - + diff --git a/security/acme-client/src/opnsense/mvc/app/views/OPNsense/AcmeClient/accounts.volt b/security/acme-client/src/opnsense/mvc/app/views/OPNsense/AcmeClient/accounts.volt index 7a95eef4b..212d76673 100644 --- a/security/acme-client/src/opnsense/mvc/app/views/OPNsense/AcmeClient/accounts.volt +++ b/security/acme-client/src/opnsense/mvc/app/views/OPNsense/AcmeClient/accounts.volt @@ -1,6 +1,6 @@ {# -Copyright (C) 2017 Frank Wall +Copyright (C) 2017-2021 Frank Wall OPNsense® is Copyright © 2014-2015 by Deciso B.V. All rights reserved. @@ -300,7 +300,7 @@ POSSIBILITY OF SUCH DAMAGE. if (gridParams['register'] != undefined) { var uuid=$(this).data("row-id"); stdDialogConfirm('{{ lang._('Confirmation Required') }}', - '{{ lang._('Register the selected account with Lets Encrypt?') }}', + '{{ lang._('Register the selected account with the configured ACME CA?') }}', '{{ lang._('Yes') }}', '{{ lang._('Cancel') }}', function() { ajaxCall(url=gridParams['register'] + uuid,sendData={},callback=function(data,status){ // reload grid afterwards diff --git a/security/acme-client/src/opnsense/scripts/OPNsense/AcmeClient/lecert.php b/security/acme-client/src/opnsense/scripts/OPNsense/AcmeClient/lecert.php index 3558d44dc..76fb546cf 100755 --- a/security/acme-client/src/opnsense/scripts/OPNsense/AcmeClient/lecert.php +++ b/security/acme-client/src/opnsense/scripts/OPNsense/AcmeClient/lecert.php @@ -41,7 +41,7 @@ use OPNsense\AcmeClient\LeCertificate; const ABOUT = << 'run automations for the specified certificate', ], 'register' => [ - 'description' => 'register the specified account with Lets Encrypt', + 'description' => 'register the specified account with ACME CA', ], ]; @@ -76,7 +76,7 @@ const STATIC_OPTIONS = << "/var/etc/acme-client/challenges/.well-known/acme-challenge/" ) # Maximum idle time with nothing being written