From 5962dc7c1828e7303d26f145e83aac7456c066bd Mon Sep 17 00:00:00 2001 From: Franco Fichtner Date: Tue, 28 Oct 2025 15:24:25 +0100 Subject: [PATCH] net/upnp: switch to mwexecf variants PR: https://github.com/opnsense/core/issues/9325 --- net/upnp/Makefile | 1 + net/upnp/src/etc/inc/plugins.inc.d/miniupnpd.inc | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/net/upnp/Makefile b/net/upnp/Makefile index ea12da552..1f5e023a7 100644 --- a/net/upnp/Makefile +++ b/net/upnp/Makefile @@ -1,5 +1,6 @@ PLUGIN_NAME= upnp PLUGIN_VERSION= 1.7 +PLUGIN_REVISION= 1 PLUGIN_DEPENDS= miniupnpd PLUGIN_COMMENT= Universal Plug and Play (UPnP IGD & PCP/NAT-PMP) Service PLUGIN_MAINTAINER= franco@opnsense.org diff --git a/net/upnp/src/etc/inc/plugins.inc.d/miniupnpd.inc b/net/upnp/src/etc/inc/plugins.inc.d/miniupnpd.inc index 6214f4ce0..5a283d096 100644 --- a/net/upnp/src/etc/inc/plugins.inc.d/miniupnpd.inc +++ b/net/upnp/src/etc/inc/plugins.inc.d/miniupnpd.inc @@ -75,15 +75,15 @@ function miniupnpd_start() return; } - mwexec_bg('/usr/local/sbin/miniupnpd -f /var/etc/miniupnpd.conf -P /var/run/miniupnpd.pid'); + mwexecf_bg('/usr/local/sbin/miniupnpd -f %s -P %s', [ '/var/etc/miniupnpd.conf', '/var/run/miniupnpd.pid']); } function miniupnpd_stop() { killbypid('/var/run/miniupnpd.pid'); - mwexec('/sbin/pfctl -aminiupnpd -Fr 2>&1 >/dev/null'); - mwexec('/sbin/pfctl -aminiupnpd -Fn 2>&1 >/dev/null'); + mwexecf('/sbin/pfctl -a miniupnpd -Fr'); + mwexecf('/sbin/pfctl -a miniupnpd -Fn'); } function miniupnpd_configure()