From 50c9cb095a04c05f83367c2922ecdea0d79aa8d4 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <ad@opnsense.org>
Date: Fri, 14 Mar 2025 13:23:25 +0100
Subject: [PATCH] sysutils/sftp-backup :  fix identity comparison for
 https://github.com/opnsense/plugins/issues/4582

---
 .../src/opnsense/mvc/app/library/OPNsense/Backup/Sftp.php    | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sysutils/sftp-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Sftp.php b/sysutils/sftp-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Sftp.php
index 90c2e5aba..75846a652 100644
--- a/sysutils/sftp-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Sftp.php
+++ b/sysutils/sftp-backup/src/opnsense/mvc/app/library/OPNsense/Backup/Sftp.php
@@ -177,8 +177,9 @@ class Sftp extends Base implements IBackupProvider
         if (!is_dir($confdir)) {
             mkdir($confdir);
         }
-        if (!is_file($identfile) || file_get_contents($identfile) != $this->model->privkey) {
-            File::file_put_contents($identfile, trim(str_replace("\r", "", $this->model->privkey)) . "\n", 0600);
+        $this_key = trim(str_replace("\r", "", $this->model->privkey)) . "\n";
+        if (!is_file($identfile) || file_get_contents($identfile) != $this_key) {
+            File::file_put_contents($identfile, $this_key, 0600);
         }
         return $identfile;
     }