From 32f3408f19f58e70c3153486ce24e2e1f9982922 Mon Sep 17 00:00:00 2001 From: SaarLAN-Pissbeutel <183202051+SaarLAN-Pissbeutel@users.noreply.github.com> Date: Sun, 2 Feb 2025 13:33:51 +0100 Subject: [PATCH] dns/ddclient: Fix Netcup host/domain recognition (#4516) * Fix ddclient netcup host/domain recognition * Update dns/ddclient/src/opnsense/scripts/ddclient/lib/account/netcup.py Co-authored-by: Ad Schellevis --------- Co-authored-by: Ad Schellevis --- .../src/opnsense/scripts/ddclient/lib/account/netcup.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/netcup.py b/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/netcup.py index 9bb775c1e..10322a630 100755 --- a/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/netcup.py +++ b/dns/ddclient/src/opnsense/scripts/ddclient/lib/account/netcup.py @@ -64,7 +64,8 @@ class Netcup(BaseAccount): syslog.syslog(syslog.LOG_ERR, "Incomplete FQDN offerred %s" % self.settings['hostnames']) return False - self.hostname, self.domain = self.settings['hostnames'].split('.', 1) + self.domain = self.settings['hostnames'].split('.', self.settings['hostnames'].count('.')-1)[-1] + self.hostname = self.settings['hostnames'].rsplit('.', 2)[0] if self.domain != self.settings['hostnames'] else '@' if self.settings['password'].count('|') == 1: self.settings['APIPassword'], self.settings['APIKey'] = self.settings['password'].split('|')