From 297335efbf863ac14ab0187f1cd843679984c382 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Fri, 13 Sep 2024 11:35:09 +0200
Subject: [PATCH] dns/ddclient: fix ACLs due to lint-acl addition

---
 .../src/opnsense/mvc/app/models/OPNsense/DynDNS/ACL/ACL.xml   | 4 +++-
 dns/ddclient/src/opnsense/www/js/widgets/Dyndns.js            | 4 ++--
 dns/ddclient/src/opnsense/www/js/widgets/Metadata/Dyndns.xml  | 3 ++-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/ACL/ACL.xml b/dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/ACL/ACL.xml
index 4503995ce..32da0de0b 100644
--- a/dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/ACL/ACL.xml
+++ b/dns/ddclient/src/opnsense/mvc/app/models/OPNsense/DynDNS/ACL/ACL.xml
@@ -2,8 +2,10 @@
     <page-services-dyndns>
         <name>Services: Dynamic DNS</name>
         <patterns>
+            <pattern>api/dyndns/accounts/*</pattern>
+            <pattern>api/dyndns/service/*</pattern>
+            <pattern>api/dyndns/settings/*</pattern>
             <pattern>ui/dyndns/*</pattern>
-            <pattern>api/dyndns/*</pattern>
         </patterns>
     </page-services-dyndns>
 </acl>
diff --git a/dns/ddclient/src/opnsense/www/js/widgets/Dyndns.js b/dns/ddclient/src/opnsense/www/js/widgets/Dyndns.js
index e4fb01095..bc4c359ab 100644
--- a/dns/ddclient/src/opnsense/www/js/widgets/Dyndns.js
+++ b/dns/ddclient/src/opnsense/www/js/widgets/Dyndns.js
@@ -52,14 +52,14 @@ export default class Dyndns extends BaseTableWidget {
 
     async onWidgetTick() {
         // Check if DynDNS is enabled
-        const statusData = await this.ajaxCall('/api/dyndns/service/status');
+        const statusData = await this.ajaxCall(`/api/dyndns/service/${'status'}`);
         if (!statusData || statusData.status !== "running") {
             this.displayError(this.translations.servicedisabled);
             return;
         }
 
         // Fetch DynDNS account information
-        const accountData = await this.ajaxCall('/api/dyndns/accounts/search_item');
+        const accountData = await this.ajaxCall(`/api/dyndns/accounts/${'search_item'}`);
         if (!accountData || !accountData.rows || accountData.rows.length === 0) {
             this.displayError(this.translations.noaccount);
             return;
diff --git a/dns/ddclient/src/opnsense/www/js/widgets/Metadata/Dyndns.xml b/dns/ddclient/src/opnsense/www/js/widgets/Metadata/Dyndns.xml
index 43a822cb3..17569ac10 100644
--- a/dns/ddclient/src/opnsense/www/js/widgets/Metadata/Dyndns.xml
+++ b/dns/ddclient/src/opnsense/www/js/widgets/Metadata/Dyndns.xml
@@ -2,7 +2,8 @@
     <ddclient>
         <filename>Dyndns.js</filename>
         <endpoints>
-            <endpoint>/api/dyndns/*</endpoint>
+            <endpoint>/api/dyndns/accounts/*</endpoint>
+            <endpoint>/api/dyndns/service/*</endpoint>
         </endpoints>
         <translations>
             <title>Dynamic DNS</title>