From 10b235e3d8fe267ed518f5a42c389a0929057ef4 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Wed, 24 Feb 2021 10:22:22 +0100
Subject: [PATCH 1/2] Framework: use -v rather than -V for full expansion

---
 Makefile           | 4 ++--
 Scripts/revbump.sh | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Makefile b/Makefile
index 82aa061e9..76fc96735 100644
--- a/Makefile
+++ b/Makefile
@@ -38,8 +38,8 @@ PLUGIN_DIRS+=	${_${CATEGORY}}
 
 list:
 .for PLUGIN_DIR in ${PLUGIN_DIRS}
-	@echo ${PLUGIN_DIR} -- $$(${MAKE} -C ${PLUGIN_DIR} -V PLUGIN_COMMENT) \
-	    $$(if [ -n "$$(${MAKE} -C ${PLUGIN_DIR} -V PLUGIN_DEVEL _PLUGIN_DEVEL=)" ]; then echo "(development only)"; fi)
+	@echo ${PLUGIN_DIR} -- $$(${MAKE} -C ${PLUGIN_DIR} -v PLUGIN_COMMENT) \
+	    $$(if [ -n "$$(${MAKE} -C ${PLUGIN_DIR} -v PLUGIN_DEVEL _PLUGIN_DEVEL=)" ]; then echo "(development only)"; fi)
 .endfor
 
 # shared targets that are sane to run from the root directory
diff --git a/Scripts/revbump.sh b/Scripts/revbump.sh
index 120b0fce4..31f1fa974 100755
--- a/Scripts/revbump.sh
+++ b/Scripts/revbump.sh
@@ -8,7 +8,7 @@ if [ -z "${DIR}" ]; then
 	DIR=.
 fi
 
-REV=$(make -C ${DIR} -V PLUGIN_REVISION)
+REV=$(make -C ${DIR} -v PLUGIN_REVISION)
 REV=$(expr ${REV} \+ 1)
 
 grep -v ^PLUGIN_REVISION ${DIR}/Makefile > ${DIR}/Makefile.tmp

From a20b641219e0f03f14e7468ba1ba6374d3f70a78 Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Wed, 24 Feb 2021 10:25:41 +0100
Subject: [PATCH 2/2] net/haproxy: whitespace cleanups

---
 .../controllers/OPNsense/HAProxy/Api/ExportController.php    | 2 +-
 .../scripts/OPNsense/HAProxy/lib/haproxy/tests/test_cmds.py  | 5 ++---
 .../src/opnsense/service/conf/actions.d/actions_haproxy.conf | 1 -
 .../src/opnsense/service/templates/OPNsense/HAProxy/+TARGETS | 2 +-
 .../service/templates/OPNsense/HAProxy/sslCerts.yaml         | 2 +-
 5 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/Api/ExportController.php b/net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/Api/ExportController.php
index 5a3cd58f9..dbf6ed915 100644
--- a/net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/Api/ExportController.php
+++ b/net/haproxy/src/opnsense/mvc/app/controllers/OPNsense/HAProxy/Api/ExportController.php
@@ -68,7 +68,7 @@ class ExportController extends ApiControllerBase
      * @return array|mixed
      */
     public function downloadAction($type)
-    {               
+    {
         $backend = new Backend();
 
         if ($type == 'config') {
diff --git a/net/haproxy/src/opnsense/scripts/OPNsense/HAProxy/lib/haproxy/tests/test_cmds.py b/net/haproxy/src/opnsense/scripts/OPNsense/HAProxy/lib/haproxy/tests/test_cmds.py
index 18a175aee..327787163 100755
--- a/net/haproxy/src/opnsense/scripts/OPNsense/HAProxy/lib/haproxy/tests/test_cmds.py
+++ b/net/haproxy/src/opnsense/scripts/OPNsense/HAProxy/lib/haproxy/tests/test_cmds.py
@@ -48,7 +48,7 @@ class TestCommands(unittest.TestCase):
         pKmFJ2e2VSnTZIBJvD58HMR+WNAEp7tHffHk2z/mPPtdRdxW5Zieoe5+6+HDtwgG
         +VCAIWMkC36Dvg==
         -----END CERTIFICATE-----
-        
+
         -----BEGIN RSA PRIVATE KEY-----
         MIIJKgIBAAKCAgEAvsNKU59F2gpl1fzbk7hD64Q3zk1hH9Im1IsN9ppF5tqdsPPG
         n3Q8QgcKpnJ/SrtnPl4Xqp3bJyV20lJWTxuVU7ImM8g4tStQB4XojTtv8A4E7/wN
@@ -100,8 +100,7 @@ class TestCommands(unittest.TestCase):
         9WYZS7hlKyqVBESJuonR15biy7Xov5ELl6A821cskZO3vTwtlBSeCDiqaeVLpKR3
         aYwf5YZo7v+N8KBSLEdLNjoKK4PfXUdczD7uOUllbd4/MRgCn4EmFvmpljGiEQ==
         -----END RSA PRIVATE KEY-----
-        
-        
+
         -----BEGIN CERTIFICATE-----
         MIIEqzCCApOgAwIBAgIRAIvhKg5ZRO08VGQx8JdhT+UwDQYJKoZIhvcNAQELBQAw
         GjEYMBYGA1UEAwwPRmFrZSBMRSBSb290IFgxMB4XDTE2MDUyMzIyMDc1OVoXDTM2
diff --git a/net/haproxy/src/opnsense/service/conf/actions.d/actions_haproxy.conf b/net/haproxy/src/opnsense/service/conf/actions.d/actions_haproxy.conf
index 1e45bc954..fcd742c0c 100644
--- a/net/haproxy/src/opnsense/service/conf/actions.d/actions_haproxy.conf
+++ b/net/haproxy/src/opnsense/service/conf/actions.d/actions_haproxy.conf
@@ -127,4 +127,3 @@ parameters:
 type:script_output
 description:Update HAProxy OCSP data
 message:update haproxy ocsp data
-
diff --git a/net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/+TARGETS b/net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/+TARGETS
index 389191f4d..b42f343eb 100644
--- a/net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/+TARGETS
+++ b/net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/+TARGETS
@@ -1,3 +1,3 @@
 haproxy.conf:/usr/local/etc/haproxy.conf.staging
 rc.conf.d:/etc/rc.conf.d/haproxy
-sslCerts.yaml:/usr/local/etc/haproxy/sslCerts.yaml
\ No newline at end of file
+sslCerts.yaml:/usr/local/etc/haproxy/sslCerts.yaml
diff --git a/net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/sslCerts.yaml b/net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/sslCerts.yaml
index 56fed4573..fd766e002 100644
--- a/net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/sslCerts.yaml
+++ b/net/haproxy/src/opnsense/service/templates/OPNsense/HAProxy/sslCerts.yaml
@@ -58,4 +58,4 @@ frontends:
 {%  endfor %}
 {% else %}
 frontends: {}
-{% endif %}
\ No newline at end of file
+{% endif %}