From 25b4d659576a3d050042ac6d74f4317a17b22f9f Mon Sep 17 00:00:00 2001
From: Franco Fichtner <franco@opnsense.org>
Date: Fri, 19 Sep 2025 13:51:32 +0200
Subject: [PATCH] security/netbird: fix selectpicker and unbreak migration

The auth key may be required but not giving a default for obvious
reasons just makes it end up without a required value anyway until
user contact.

This can probably be made more robust in the future, but requires
a bit of thought on what we validate/enforce here anyway like an
"enbable" checkbox being checked requires filling this value, but
it's also not on the same page or model even making constraints
tricky.
---
 .../mvc/app/models/OPNsense/Netbird/Authentication.xml       | 2 +-
 .../opnsense/mvc/app/views/OPNsense/Netbird/settings.volt    | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/security/netbird/src/opnsense/mvc/app/models/OPNsense/Netbird/Authentication.xml b/security/netbird/src/opnsense/mvc/app/models/OPNsense/Netbird/Authentication.xml
index c12afa3b2..b9ac20dd2 100644
--- a/security/netbird/src/opnsense/mvc/app/models/OPNsense/Netbird/Authentication.xml
+++ b/security/netbird/src/opnsense/mvc/app/models/OPNsense/Netbird/Authentication.xml
@@ -8,7 +8,7 @@
             <Default>https://api.netbird.io:443</Default>
         </managementUrl>
         <setupKey type="TextField">
-            <Required>Y</Required>
+            <!-- XXX fails migration for obvious reasons <Required>Y</Required> -->
             <Mask>/^[0-9A-F]{8}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{4}-[0-9A-F]{12}$/i</Mask>
             <ValidationMessage>Please specify a valid setup key.</ValidationMessage>
         </setupKey>
diff --git a/security/netbird/src/opnsense/mvc/app/views/OPNsense/Netbird/settings.volt b/security/netbird/src/opnsense/mvc/app/views/OPNsense/Netbird/settings.volt
index 97bb7e39d..7c505a7a1 100644
--- a/security/netbird/src/opnsense/mvc/app/views/OPNsense/Netbird/settings.volt
+++ b/security/netbird/src/opnsense/mvc/app/views/OPNsense/Netbird/settings.volt
@@ -29,9 +29,8 @@
 
 <script>
     $(document).ready(() => {
-        mapDataToFormUI({
-            'frmSettings': "/api/netbird/settings/get"
-        }).done(() => {
+        mapDataToFormUI({'frmSettings': '/api/netbird/settings/get'}).done(() => {
+            $('.selectpicker').selectpicker('refresh');
             updateServiceControlUI('netbird');
         });