From 008da911f577ebd1345e185c6080df32863d6d15 Mon Sep 17 00:00:00 2001
From: Ad Schellevis <AdSchellevis@users.noreply.github.com>
Date: Thu, 20 May 2021 18:17:44 +0200
Subject: [PATCH] net/relayd: Usability improvements
 https://github.com/opnsense/plugins/issues/2232 (#2398)

minor visual improvements on the status page.

o reset cursor pointer on status widgets
o in host column add one button spacing for better alignment
o add a space between buttons and text
---
 .../mvc/app/views/OPNsense/Relayd/status.volt       | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/net/relayd/src/opnsense/mvc/app/views/OPNsense/Relayd/status.volt b/net/relayd/src/opnsense/mvc/app/views/OPNsense/Relayd/status.volt
index c3a15c73b..0d7a42271 100644
--- a/net/relayd/src/opnsense/mvc/app/views/OPNsense/Relayd/status.volt
+++ b/net/relayd/src/opnsense/mvc/app/views/OPNsense/Relayd/status.volt
@@ -33,7 +33,7 @@ POSSIBILITY OF SUCH DAMAGE.
        * create status and start/stop buttons
        **/
       function getControlButtons(status, id, nodeType) {
-          let status_btn = $('<button class="label label-opnsense label-opnsense-xs"/>');
+          let status_btn = $('<button class="label label-opnsense label-opnsense-xs"/>').css('cursor', 'auto');
           let action_btn = $('<button class="btn btn-xs btn-default" data-toggle="tooltip"/>').attr('data-nodeid', id).attr('data-nodetype', nodeType);
           let action_btn_remove = action_btn.clone(true);
           let response = [];
@@ -75,6 +75,14 @@ POSSIBILITY OF SUCH DAMAGE.
           if (nodeType === 'relay') {
               action_btn.removeClass('node_action').attr('disabled', 'disabled');
           }
+
+          if (nodeType == 'host' && response.length == 2) {
+              response.push(
+                $('<button class="label label-opnsense label-opnsense-xs"/>').css('cursor', 'auto').css('opacity', '0').append(
+                    $("<i class='fa fa-fw'/>")
+                )
+              );
+          }
           return response;
       };
 
@@ -160,6 +168,7 @@ POSSIBILITY OF SUCH DAMAGE.
                     $vs_td.append(
                         $('<div class="object_container"/>').append(
                             getControlButtons(virtualserver.status, virtualserver.id, virtualserver.type),
+                            '&nbsp;',
                             virtualserver.name,
                             listen_str,
                             ' (' + virtualserver.type + '): ',
@@ -174,6 +183,7 @@ POSSIBILITY OF SUCH DAMAGE.
                             $tbl_td.append(
                                 $('<div class="object_container"/>').append(
                                     getControlButtons(table.status, tkey, 'table'),
+                                    '&nbsp;',
                                     table.name + ' ' + table.status
                                 ).data('payload', table).data('type', 'table')
                             );
@@ -195,6 +205,7 @@ POSSIBILITY OF SUCH DAMAGE.
                                     $host_td.append(
                                         $('<div class="object_container"/>').append(
                                             getControlButtons(host.status, hkey, 'host'),
+                                            '&nbsp;',
                                             display_name,
                                             " ",
                                             host.status