1 Commits

Include renames

Author	SHA1	Message	Date
Zoltan Papp	2768bf2d67	Refactor own profile management in the Go core (#147) ... * refactor(ios): own profile management in the Go core Replace the parallel Swift profile manager with a thin wrapper over the core's ID-based profilemanager.ServiceManager (via the new NetBirdSDK iOS binding), eliminating the duplicate implementation. Profiles are now ID-keyed (on-disk filename = id, display name lives in the config); the default profile stays "default" at the container root and never becomes a hex id, matching the Go/desktop semantics. - ProfileManager: thin wrapper over NetBirdSDKProfileManager on iOS; tvOS keeps its single-default, container-root behavior (no Go profile manager) - ProfileLayoutMigration: one-time, idempotent, file-coordinated migration from the legacy profiles/<name>/ directory layout to the Go layout; preserves auth tokens (copies unparseable configs verbatim), keeps the active selection and logged-out profiles, and only marks itself done on full success so a failure retries on the next launch - ProfileConnectionCache and all callers re-keyed by profile id - Settings/server changes already target the active profile through the profile manager (Preferences.configFile -> activeConfigPath) - Tests: NetBirdTests/ProfileMigrationTests covers the migration, reads it back through the Go lib, and round-trips a setting via NetBirdSDKPreferences (the test target now links NetBirdSDK) - Bump netbird-core submodule to include the iOS profile manager binding * ci: re-enable Test workflow on push and pull_request Run the iOS test suite on PRs again to check whether the previously reported test crash still reproduces. * fix(ios): call gomobile path getters with NSErrorPointer The non-null String path getters (getActiveConfigPath/getActiveStateFilePath/getConfigPath/getStateFilePath) are generated by gomobile as value-returning calls with an explicit NSErrorPointer parameter, not throwing methods. Wrap them via a goPath helper in ProfileManager (and matching helpers in the tests), fixing the iOS app build failure (missing argument for parameter). * fix(ios): raise NetBirdTests deployment target to iOS 15.0 The NetBirdTests target was iOS 14.0 while the NetBird app module requires iOS 15.0, so `@testable import NetBird` failed to build ("Compiling for iOS 14.0, but module 'NetBird' has a minimum deployment target of iOS 15.0"). Match the test target to the app so the test bundle compiles and the suite can run. * ci(ios): use valid GOOGLE_APP_ID in dummy Firebase plist The dummy GoogleService-Info.plist used a GOOGLE_APP_ID of "dummy", which fails Firebase's app-ID format validation. At launch the host app calls FirebaseApp.configure(options:), and +[FIRApp addAppToAppDictionary:] raised an uncaught NSException, aborting the host before the test runner could establish a connection ("Test crashed with signal abrt before establishing connection"). This blocked all hosted tests, not just the new profile-migration ones. Give the dummy app ID a well-formed value so configure() succeeds. * fix(ios): skip Firebase configuration under unit tests The host app calls FirebaseApp.configure() at launch. When launched purely to host unit tests, this aborted the process before the test runner could connect because FirebaseApp.configure() raises an uncaught ObjC exception on an invalid app ID (the CI dummy plist). Gate both the iOS and tvOS configure paths on the XCTestConfigurationFilePath environment variable so Firebase is never initialized in the test host, and fold the duplicated configure logic into a single helper. * test(ios): write ManagementURL as Go-style object in migration fixtures The legacy netbird.cfg is written by the Go SDK, which serializes Config.ManagementURL (a url.URL) as a nested {Scheme,Host,Path} object, not a plain string. The settings round-trip test drives NetBirdSDKPreferences, which fully unmarshals Config and rejected the string fixture with "cannot unmarshal string into Go struct field Config.ManagementURL". Normalize the fixture to the object form the SDK actually produces. * fix(ios): narrow NetBirdTests FRAMEWORK_SEARCH_PATHS to project dir The test target used a recursive "$(PROJECT_DIR)/**" framework search path, scanning every subdirectory (DerivedData, netbird-core, package checkouts) and risking unexpected framework resolution. NetBirdSDK.xcframework lives at the project root, so point the search path at "$(PROJECT_DIR)" directly. * chore(ios): bump netbird-core to preserve profile name on auth save * feat(ios): exclude profile storage from device backups The profile configs carry the WireGuard and SSH private keys, and the WireGuard key is the peer's identity: restoring a backup onto another device would produce two devices connecting with the same key. Mark the profiles/ directory and the container-root profile files (netbird.cfg, state.json, active_profile.json, netbird_server_url) as excluded from iCloud/iTunes backups. The exclusion is re-applied on every launch from the ProfileManager init: the Go core rewrites some of these files via temp-file+rename, which drops per-file attributes. The profiles/ directory is excluded as a whole (and created up front if missing), so its contents stay covered regardless of how they are rewritten. After a restore the user re-logs in, matching how a profile behaves when moved to a new machine on desktop. * Bump netbird-core submodule to main (ed7d4de99)	2026-08-26 11:54:21 +02:00