From eab497aa25b8e4ebfc7f5830abd608fa31242a05 Mon Sep 17 00:00:00 2001 From: Sean DuBois Date: Sun, 8 Dec 2019 13:36:37 -0800 Subject: [PATCH] Seed everytime when calling generateRandString This isn't in a hot path, so no performance hit. Also want to avoid side effects from doing in an init --- mdns.go | 11 ----------- util.go | 4 +--- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/mdns.go b/mdns.go index 3b06781..7188b13 100644 --- a/mdns.go +++ b/mdns.go @@ -1,9 +1,5 @@ package ice -import ( - "crypto/rand" -) - // MulticastDNSMode represents the different Multicast modes ICE can run in type MulticastDNSMode byte @@ -20,12 +16,5 @@ const ( ) func generateMulticastDNSName() (string, error) { - b := make([]byte, 16) - _, err := rand.Read(b) //nolint - - if err != nil { - return "", err - } - return generateRandString("", ".local") } diff --git a/util.go b/util.go index 152922a..d659ff3 100644 --- a/util.go +++ b/util.go @@ -81,9 +81,7 @@ func generateCandidateID() (string, error) { func generateRandString(prefix, sufix string) (string, error) { b := make([]byte, 16) - _, err := rand.Read(b) //nolint - - if err != nil { + if _, err := rand.New(rand.NewSource(time.Now().UnixNano())).Read(b); err != nil { return "", err }