From 5d2bbc818c137cc84b531ded404289d9cb07c080 Mon Sep 17 00:00:00 2001 From: Yutaka Takeda Date: Sun, 26 Jul 2020 02:00:18 -0700 Subject: [PATCH] Increase binding req timeout value Resolves #255 --- agent_config.go | 2 +- agent_test.go | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/agent_config.go b/agent_config.go index 25c38f0..c7198af 100644 --- a/agent_config.go +++ b/agent_config.go @@ -39,7 +39,7 @@ const ( maxBufferSize = 1000 * 1000 // 1MB // wait time before binding requests can be deleted - maxBindingRequestTimeout = 500 * time.Millisecond + maxBindingRequestTimeout = 4000 * time.Millisecond ) var ( diff --git a/agent_test.go b/agent_test.go index 0f9bba0..966c71e 100644 --- a/agent_test.go +++ b/agent_test.go @@ -1208,20 +1208,20 @@ func TestBindingRequestTimeout(t *testing.T) { now := time.Now() a.pendingBindingRequests = append(a.pendingBindingRequests, bindingRequest{ - timestamp: now, + timestamp: now, // valid }) a.pendingBindingRequests = append(a.pendingBindingRequests, bindingRequest{ - timestamp: now.Add(-25 * time.Millisecond), + timestamp: now.Add(-3900 * time.Millisecond), // valid }) a.pendingBindingRequests = append(a.pendingBindingRequests, bindingRequest{ - timestamp: now.Add(-750 * time.Millisecond), + timestamp: now.Add(-4100 * time.Millisecond), // invalid }) a.pendingBindingRequests = append(a.pendingBindingRequests, bindingRequest{ - timestamp: now.Add(-75 * time.Hour), + timestamp: now.Add(-75 * time.Hour), // invalid }) a.invalidatePendingBindingRequests(now) - assert.Equal(t, len(a.pendingBindingRequests), expectedRemovalCount, "Binding invalidation due to timeout did not remove the correct number of binding requests") + assert.Equal(t, expectedRemovalCount, len(a.pendingBindingRequests), "Binding invalidation due to timeout did not remove the correct number of binding requests") assert.NoError(t, a.Close()) }