From 3183920f01ceb3e613d819f9b3e7b4b81f21c24a Mon Sep 17 00:00:00 2001 From: Aleksandr Razumov Date: Tue, 4 Jun 2019 12:25:31 +0300 Subject: [PATCH] Update bad transaction ID handling for response Receiving the messages with transaction ID that is currently not in progress is expected. * Change output format to hexademical to improve readability * Change log severity to warning * Update wording (invalid -> unknown) Relates to #59 --- selection.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/selection.go b/selection.go index ebbb629..c20c57c 100644 --- a/selection.go +++ b/selection.go @@ -142,7 +142,7 @@ func (s *controllingSelector) HandleBindingRequest(m *stun.Message, local, remot func (s *controllingSelector) HandleSucessResponse(m *stun.Message, local, remote Candidate, remoteAddr net.Addr) { ok, pendingRequest := s.agent.handleInboundBindingSuccess(m.TransactionID) if !ok { - s.log.Errorf("discard message from (%s), invalid TransactionID %s", remote, m.TransactionID) + s.log.Warnf("discard message from (%s), unknown TransactionID 0x%x", remote, m.TransactionID) return } @@ -234,7 +234,7 @@ func (s *controlledSelector) HandleSucessResponse(m *stun.Message, local, remote ok, pendingRequest := s.agent.handleInboundBindingSuccess(m.TransactionID) if !ok { - s.log.Errorf("discard message from (%s), invalid TransactionID %s", remote, m.TransactionID) + s.log.Warnf("discard message from (%s), unknown TransactionID 0x%x", remote, m.TransactionID) return }