Nicolas Lacasse d22dedf3d5 Check all 3 stdio FDs to determine if terminal is connected to a pty. ...

Previously we were only looking at stdin, which could be a pty but other stdio
fds might be redirected. In that case, we can incorrectly end up using the
stdin fd as *the* console fd, and sending all stdout/stderr to that FD,
ignoring the redirect.

Note that the behavior was actually flaky because the mechanism for choosing
which stdio fd to treat as *the* pty fd is non-deterministic (due to the map
iteration in fdimport/fdimport.go:Import) and so sometimes we would choose
the correct one.

This CL also cleans up `argsFromProcess` and `argsFromCLI`, which were setting
their `FilePayload` unnecessarily, since it is always set in `Execute`.

Fixes #11350
Fixes #11349

PiperOrigin-RevId: 716733446

2025-01-17 11:15:59 -08:00

..

BUILD

Add default_applicable_licenses rules to packages.

2023-03-02 10:50:04 -08:00

console.go

Add support for TTY in multi-container

2020-11-17 14:51:24 -08:00

pty_linux.go

Check all 3 stdio FDs to determine if terminal is connected to a pty.

2025-01-17 11:15:59 -08:00