From eed95da2755e7e7ebe017f4ad61496f4e9594bed Mon Sep 17 00:00:00 2001 From: Ayush Ranjan Date: Tue, 11 Apr 2023 22:05:19 -0700 Subject: [PATCH] Actually run multiple tool tests in golang runtime test suite. Using the '\|' delimiter to separate multiple go tool tests ends up not running any test. Just using '|' works. Reported-by: Nicolas Lacasse Investigated-by: Andrei Vagin Fixed-by: Andrei Vagin PiperOrigin-RevId: 523601890 --- test/runtimes/proctor/lib/go.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/runtimes/proctor/lib/go.go b/test/runtimes/proctor/lib/go.go index 5c48fb60b..a699206e2 100644 --- a/test/runtimes/proctor/lib/go.go +++ b/test/runtimes/proctor/lib/go.go @@ -87,7 +87,7 @@ func (goRunner) TestCmds(tests []string) []*exec.Cmd { var cmds []*exec.Cmd if len(toolTests) > 0 { - cmds = append(cmds, exec.Command("go", "tool", "dist", "test", "-v", "-no-rebuild", "-run", strings.Join(toolTests, "\\|"))) + cmds = append(cmds, exec.Command("go", "tool", "dist", "test", "-v", "-no-rebuild", "-run", strings.Join(toolTests, "|"))) } if len(onDiskTests) > 0 { cmd := exec.Command("go", append([]string{"run", "run.go", "-v", "--"}, onDiskTests...)...)