From e8c45a17cf34b130af3bc50da5cc0d9ab8b9b021 Mon Sep 17 00:00:00 2001 From: Fabricio Voznika Date: Wed, 3 Aug 2022 15:26:45 -0700 Subject: [PATCH] Enable test/trace:trace_test It was mistakenly marked as manual. Updates #4805 PiperOrigin-RevId: 465163546 --- test/trace/BUILD | 1 - test/trace/trace_test.go | 12 ++++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/test/trace/BUILD b/test/trace/BUILD index 0486442a8..b9e921a07 100644 --- a/test/trace/BUILD +++ b/test/trace/BUILD @@ -13,7 +13,6 @@ go_test( library = ":trace", tags = [ "local", - "manual", ], deps = [ "//pkg/sentry/seccheck", diff --git a/test/trace/trace_test.go b/test/trace/trace_test.go index 9659917ca..806a7decc 100644 --- a/test/trace/trace_test.go +++ b/test/trace/trace_test.go @@ -108,6 +108,14 @@ func matchPoints(t *testing.T, msgs []test.Message) { pb.MessageType_MESSAGE_SYSCALL_RAW: {checker: checkSyscallRaw}, pb.MessageType_MESSAGE_SYSCALL_READ: {checker: checkSyscallRead}, pb.MessageType_MESSAGE_SYSCALL_SOCKET: {checker: checkSyscallSocket}, + + // TODO(gvisor.dev/issue/4805): Add validation for these messages. + pb.MessageType_MESSAGE_SYSCALL_ACCEPT: {checker: checkTODO}, + pb.MessageType_MESSAGE_SYSCALL_BIND: {checker: checkTODO}, + pb.MessageType_MESSAGE_SYSCALL_CLONE: {checker: checkTODO}, + pb.MessageType_MESSAGE_SYSCALL_DUP: {checker: checkTODO}, + pb.MessageType_MESSAGE_SYSCALL_PIPE: {checker: checkTODO}, + pb.MessageType_MESSAGE_SYSCALL_PRLIMIT64: {checker: checkTODO}, } for _, msg := range msgs { t.Logf("Processing message type %v", msg.MsgType) @@ -433,3 +441,7 @@ func checkSyscallSocket(msg test.Message) error { } return nil } + +func checkTODO(_ test.Message) error { + return nil +}