From d46a5b7c3be5a8465adfb01c5ff12535dfc3b7d7 Mon Sep 17 00:00:00 2001 From: Ayush Ranjan Date: Fri, 18 Oct 2024 13:45:18 -0700 Subject: [PATCH] Reduce timeout in TcpSocketTest.Closed{Read/Write}BlockingSocket. The timeout was set to 10 seconds, which is too long. Should be sufficient to timeout in 3 seconds to ensure read()/send() is blocked. These tests have multiple variants too. Together, they take too long to run. PiperOrigin-RevId: 687411356 --- test/syscalls/linux/tcp_socket.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/syscalls/linux/tcp_socket.cc b/test/syscalls/linux/tcp_socket.cc index 6a198ae3d..c8a23b0b7 100644 --- a/test/syscalls/linux/tcp_socket.cc +++ b/test/syscalls/linux/tcp_socket.cc @@ -525,7 +525,7 @@ TEST_P(TcpSocketTest, PollWithFullBufferBlocks) { TEST_P(TcpSocketTest, ClosedWriteBlockingSocket) { FillSocketBuffers(connected_.get(), accepted_.get()); - constexpr int timeout = 10; + constexpr int timeout = 3; struct timeval tv = {.tv_sec = timeout, .tv_usec = 0}; EXPECT_THAT( setsockopt(connected_.get(), SOL_SOCKET, SO_SNDTIMEO, &tv, sizeof(tv)), @@ -558,7 +558,7 @@ TEST_P(TcpSocketTest, ClosedWriteBlockingSocket) { } TEST_P(TcpSocketTest, ClosedReadBlockingSocket) { - constexpr int timeout = 10; + constexpr int timeout = 3; struct timeval tv = {.tv_sec = timeout, .tv_usec = 0}; EXPECT_THAT( setsockopt(connected_.get(), SOL_SOCKET, SO_RCVTIMEO, &tv, sizeof(tv)),