From ca8ab5d17b2cf16d442a2645bea01293b30e23e3 Mon Sep 17 00:00:00 2001 From: gVisor bot Date: Tue, 30 Jan 2024 16:46:37 -0800 Subject: [PATCH] Increase threshold for small time errors from 10 microseconds to 1 millisecond. PiperOrigin-RevId: 602878001 --- pkg/sentry/time/parameters.go | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pkg/sentry/time/parameters.go b/pkg/sentry/time/parameters.go index 1e7bfe2bb..299c38c97 100644 --- a/pkg/sentry/time/parameters.go +++ b/pkg/sentry/time/parameters.go @@ -229,15 +229,10 @@ func errorAdjust(prevParams Parameters, newParams Parameters, now TSCValue) (Par // The log level is determined by the error severity. func logErrorAdjustment(clock ClockID, errorNS ReferenceNS, orig, adjusted Parameters) { magNS := int64(errorNS.Magnitude()) - if magNS <= 10*time.Microsecond.Nanoseconds() { + if magNS <= time.Millisecond.Nanoseconds() { // Don't log small errors. return } - fn := log.Infof - if magNS > time.Millisecond.Nanoseconds() { - // Upgrade large errors to warning. - fn = log.Warningf - } - fn("Clock(%v): error: %v ns, adjusted frequency from %v Hz to %v Hz", clock, errorNS, orig.Frequency, adjusted.Frequency) + log.Warningf("Clock(%v): error: %v ns, adjusted frequency from %v Hz to %v Hz", clock, errorNS, orig.Frequency, adjusted.Frequency) }