From bfbb9fa4cce0c4ce599dd218927d40d25394f4ed Mon Sep 17 00:00:00 2001 From: Zach Koopmans Date: Tue, 29 Nov 2022 13:04:39 -0800 Subject: [PATCH] Disable process_vm_(read|write)v. Syzkaller has found several issues with the two syscalls and a rework is required. Disable tests and the syscall until issues can be fixed. PiperOrigin-RevId: 491716795 --- pkg/sentry/syscalls/linux/linux64.go | 8 ++++---- test/syscalls/BUILD | 5 ----- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/pkg/sentry/syscalls/linux/linux64.go b/pkg/sentry/syscalls/linux/linux64.go index b6abaaa40..b53db566d 100644 --- a/pkg/sentry/syscalls/linux/linux64.go +++ b/pkg/sentry/syscalls/linux/linux64.go @@ -362,8 +362,8 @@ var AMD64 = &kernel.SyscallTable{ 307: syscalls.Supported("sendmmsg", SendMMsg), 308: syscalls.ErrorWithEvent("setns", linuxerr.EOPNOTSUPP, "Needs filesystem support", []string{"gvisor.dev/issue/140"}), // TODO(b/29354995) 309: syscalls.Supported("getcpu", Getcpu), - 310: syscalls.Supported("process_vm_readv", ProcessVMReadv), - 311: syscalls.Supported("process_vm_writev", ProcessVMWritev), + 310: syscalls.ErrorWithEvent("process_vm_readv", linuxerr.ENOSYS, "", []string{"gvisor.dev/issue/158"}), // TODO(b/260724654) + 311: syscalls.ErrorWithEvent("process_vm_writev", linuxerr.ENOSYS, "", []string{"gvisor.dev/issue/158"}), // TODO(b/260724654) 312: syscalls.CapError("kcmp", linux.CAP_SYS_PTRACE, "", nil), 313: syscalls.CapError("finit_module", linux.CAP_SYS_MODULE, "", nil), 314: syscalls.ErrorWithEvent("sched_setattr", linuxerr.ENOSYS, "gVisor does not implement a scheduler.", []string{"gvisor.dev/issue/264"}), // TODO(b/118902272) @@ -685,8 +685,8 @@ var ARM64 = &kernel.SyscallTable{ 267: syscalls.Supported("syncfs", Syncfs), 268: syscalls.ErrorWithEvent("setns", linuxerr.EOPNOTSUPP, "Needs filesystem support", []string{"gvisor.dev/issue/140"}), // TODO(b/29354995) 269: syscalls.Supported("sendmmsg", SendMMsg), - 270: syscalls.Supported("process_vm_readv", ProcessVMReadv), - 271: syscalls.Supported("process_vm_writev", ProcessVMWritev), + 270: syscalls.ErrorWithEvent("process_vm_readv", linuxerr.ENOSYS, "", []string{"gvisor.dev/issue/158"}), // TODO(b/260724654) + 271: syscalls.ErrorWithEvent("process_vm_writev", linuxerr.ENOSYS, "", []string{"gvisor.dev/issue/158"}), // TODO(b/260724654) 272: syscalls.CapError("kcmp", linux.CAP_SYS_PTRACE, "", nil), 273: syscalls.CapError("finit_module", linux.CAP_SYS_MODULE, "", nil), 274: syscalls.ErrorWithEvent("sched_setattr", linuxerr.ENOSYS, "gVisor does not implement a scheduler.", []string{"gvisor.dev/issue/264"}), // TODO(b/118902272) diff --git a/test/syscalls/BUILD b/test/syscalls/BUILD index 48993b6e0..128b59c82 100644 --- a/test/syscalls/BUILD +++ b/test/syscalls/BUILD @@ -1084,8 +1084,3 @@ syscall_test( size = "small", test = "//test/syscalls/linux:close_range_test", ) - -syscall_test( - size = "small", - test = "//test/syscalls/linux:process_vm_read_write", -)