From aadfe7f23ca4f7861eddcedf47ffbfcadbc8424d Mon Sep 17 00:00:00 2001 From: Ayush Ranjan Date: Tue, 12 Jul 2022 13:44:11 -0700 Subject: [PATCH] Skip fpsig_fork_test on ptrace platform. There was a kernel bug introduced in 43be46e89698 ("x86/fpu: Sanitize xstateregs_set()") which is causing this test to break on ptrace platform. This commit was bisected by Andrei Vagin. Quoting Andrei: "The problem is that mxcsr isn't changed if a new fpstate doesn't have one of SSE, YMM, FP features." PiperOrigin-RevId: 460543091 --- test/syscalls/linux/fpsig_fork.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/syscalls/linux/fpsig_fork.cc b/test/syscalls/linux/fpsig_fork.cc index 79b0596c4..3385df33d 100644 --- a/test/syscalls/linux/fpsig_fork.cc +++ b/test/syscalls/linux/fpsig_fork.cc @@ -68,6 +68,8 @@ void sigusr1(int s, siginfo_t* siginfo, void* _uc) { } TEST(FPSigTest, Fork) { + // NOTE(b/238773725): This test fails on ptrace platform due to a kernel bug. + SKIP_IF(GvisorPlatform() == Platform::kPtrace); parent = getpid(); pid_t parent_tid = gettid(); @@ -135,6 +137,8 @@ TEST(FPSigTest, Fork) { #ifdef __x86_64__ TEST(FPSigTest, ForkWithZeroMxcsr) { + // NOTE(b/238773725): This test fails on ptrace platform due to a kernel bug. + SKIP_IF(GvisorPlatform() == Platform::kPtrace); parent = getpid(); pid_t parent_tid = gettid();