netbird/gvisor
0
0
Fork 0
mirror of https://github.com/netbirdio/gvisor.git synced 2026-05-22 17:12:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Check hard link target's mount compatibility before kernfs.Dentry cast.

Browse Source 
Reported-by: syzbot+65dcd89bab032fdb8ac8@syzkaller.appspotmail.com
PiperOrigin-RevId: 507832777
This commit is contained in:
Ayush Ranjan
2023-02-07 11:17:27 -08:00
committed by gVisor bot
parent be5314c5a6
commit 8373fb5db8
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/sentry/fsimpl/kernfs/filesystem.go
+5 -5
View File
@@ -362,8 +362,9 @@ func (fs *Filesystem) LinkAt(ctx context.Context, rp *vfs.ResolvingPath, vd vfs.
return err return err
} }
parent.dirMu.Lock() if rp.Mount() != vd.Mount() {
defer parent.dirMu.Unlock() return linuxerr.EXDEV
}
inode := vd.Dentry().Impl().(*Dentry).Inode() inode := vd.Dentry().Impl().(*Dentry).Inode()
if inode.Mode().IsDir() { if inode.Mode().IsDir() {
return linuxerr.EPERM return linuxerr.EPERM
@@ -371,6 +372,8 @@ func (fs *Filesystem) LinkAt(ctx context.Context, rp *vfs.ResolvingPath, vd vfs.
if err := vfs.MayLink(rp.Credentials(), inode.Mode(), inode.UID(), inode.GID()); err != nil { if err := vfs.MayLink(rp.Credentials(), inode.Mode(), inode.UID(), inode.GID()); err != nil {
return err return err
} }
parent.dirMu.Lock()
defer parent.dirMu.Unlock()
pc := rp.Component() pc := rp.Component()
if err := checkCreateLocked(ctx, rp.Credentials(), pc, parent); err != nil { if err := checkCreateLocked(ctx, rp.Credentials(), pc, parent); err != nil {
return err return err
@@ -378,9 +381,6 @@ func (fs *Filesystem) LinkAt(ctx context.Context, rp *vfs.ResolvingPath, vd vfs.
if rp.MustBeDir() { if rp.MustBeDir() {
return linuxerr.ENOENT return linuxerr.ENOENT
} }
if rp.Mount() != vd.Mount() {
return linuxerr.EXDEV
}
if err := rp.Mount().CheckBeginWrite(); err != nil { if err := rp.Mount().CheckBeginWrite(); err != nil {
return err return err
} }