From 7045828a310d47a2940214f71ae75b8b7b682b78 Mon Sep 17 00:00:00 2001 From: Michael Pratt Date: Fri, 7 Sep 2018 18:13:50 -0700 Subject: [PATCH] Update cleanup TODO PiperOrigin-RevId: 212068327 Change-Id: I3f360cdf7d6caa1c96fae68ae3a1caaf440f0cbe --- pkg/sentry/sighandling/sighandling.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/sentry/sighandling/sighandling.go b/pkg/sentry/sighandling/sighandling.go index b08588c11..0946ab075 100644 --- a/pkg/sentry/sighandling/sighandling.go +++ b/pkg/sentry/sighandling/sighandling.go @@ -87,9 +87,8 @@ func forwardSignals(k *kernel.Kernel, sigchans []chan os.Signal, start, stop, do // // Otherwise ignore the signal. // - // TODO: Convert Go's runtime.raise from - // tkill to tgkill so PrepareForwarding doesn't need to - // be called until after filter installation. + // TODO: Drop in Go 1.12, which uses tgkill + // in runtime.raise. switch signal { case linux.SIGHUP, linux.SIGINT, linux.SIGTERM: dieFromSignal(signal)