From 657b563a56e8999d281e8928c7cc313e696b5499 Mon Sep 17 00:00:00 2001 From: Etienne Perot Date: Thu, 15 Feb 2024 12:27:25 -0800 Subject: [PATCH] Re-enable `textgen_test`. BuildKite images are now preloaded with the GPU Docker images, so this should no longer be an issue. Startblock: cl/607144026 is submitted PiperOrigin-RevId: 607418077 --- Makefile | 3 +-- test/gpu/textgen_test.go | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 36b6072e9..3bb186e5f 100644 --- a/Makefile +++ b/Makefile @@ -293,8 +293,7 @@ cos-gpu-smoke-tests: gpu-smoke-images $(RUNTIME_BIN) # This is a superset of those needed for smoke tests. # It includes non-GPU images that are used as part of GPU tests, # e.g. busybox and python. -# TODO(b/306706609): Add "load-gpu_ollama" and "load-basic_busybox" back here. -gpu-images: gpu-smoke-images load-gpu_pytorch load-basic_python +gpu-images: gpu-smoke-images load-gpu_pytorch load-gpu_ollama load-basic_busybox load-basic_python .PHONY: gpu-images gpu-all-tests: gpu-images gpu-smoke-tests $(RUNTIME_BIN) diff --git a/test/gpu/textgen_test.go b/test/gpu/textgen_test.go index 1fa63766c..f25483639 100644 --- a/test/gpu/textgen_test.go +++ b/test/gpu/textgen_test.go @@ -66,7 +66,6 @@ func runSandboxedPython(ctx context.Context, logger testutil.Logger, code string // Then it asks it to write a unit test that verifies that // this text is a correct translation. func TestLLM(t *testing.T) { - t.Skip("Test is disabled until support for large images is better.") ctx := context.Background() // Run the LLM. llmContainer := dockerutil.MakeContainer(ctx, t)