From 5b30c4a27543f14351b154d775f5ce315010abc7 Mon Sep 17 00:00:00 2001 From: Jamie Liu Date: Wed, 3 Apr 2024 13:42:54 -0700 Subject: [PATCH] Downgrade rseq test TODOs to NOTEs. PiperOrigin-RevId: 621626382 --- test/syscalls/linux/rseq.cc | 2 +- test/syscalls/linux/rseq/start_arm64.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/syscalls/linux/rseq.cc b/test/syscalls/linux/rseq.cc index 520a083e9..9284c8d6f 100644 --- a/test/syscalls/linux/rseq.cc +++ b/test/syscalls/linux/rseq.cc @@ -197,7 +197,7 @@ TEST(RseqTest, InvalidAbortClearsCS) { RunChildTest(kRseqTestInvalidAbortClearsCS, 0); } -// TODO(b/326665974): Implement clone() in rseq/start_arm64.S. +// NOTE(b/326665974): Needs implementation of clone() in rseq/start_arm64.S. #if defined(__x86_64__) TEST(RseqTest, MembarrierResetsCpuIdStart) { SKIP_IF(!ASSERT_NO_ERRNO_AND_VALUE(RSeqSupported())); diff --git a/test/syscalls/linux/rseq/start_arm64.S b/test/syscalls/linux/rseq/start_arm64.S index 8e8c2c8e0..2a9558491 100644 --- a/test/syscalls/linux/rseq/start_arm64.S +++ b/test/syscalls/linux/rseq/start_arm64.S @@ -49,7 +49,7 @@ raw_syscall: .type clone, @function clone: - // TODO(b/326665974) + // NOTE(b/326665974): implement me mov x0,#-38 // ENOSYS ret