From 543a60e4a13d99f88b93cbe3030de663b9fc3909 Mon Sep 17 00:00:00 2001 From: Nayana Bidari Date: Tue, 30 May 2023 22:44:52 -0700 Subject: [PATCH] Fix tcp test flake. Verify the SackedOut value only when the connection is not in any recovery. Before: http://sponge2/84d99422-bbd6-4ae8-992f-da9501da2dca After: http://sponge2/bc143f42-b56a-405a-b7ad-115447dc75f4 PiperOrigin-RevId: 536606932 --- pkg/tcpip/transport/tcp/test/e2e/tcp_rack_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pkg/tcpip/transport/tcp/test/e2e/tcp_rack_test.go b/pkg/tcpip/transport/tcp/test/e2e/tcp_rack_test.go index 0fd3322cb..96b9c6945 100644 --- a/pkg/tcpip/transport/tcp/test/e2e/tcp_rack_test.go +++ b/pkg/tcpip/transport/tcp/test/e2e/tcp_rack_test.go @@ -973,9 +973,10 @@ func TestRACKUpdateSackedOut(t *testing.T) { t.Fatalf("SackedOut got updated to wrong value got: %v want: 2", state.Sender.SackedOut) } - if state.Sender.SackedOut != 0 && ackNum == 1 { + if !state.Sender.FastRecovery.Active && state.Sender.SackedOut != 0 && ackNum == 1 { t.Fatalf("SackedOut got updated to wrong value got: %v want: 0", state.Sender.SackedOut) } + if ackNum > 0 { close(probeDone) }