From 426d08bdabd87cb9c4979937a541d30107893f25 Mon Sep 17 00:00:00 2001 From: Ayush Ranjan Date: Mon, 13 May 2024 07:16:51 -0700 Subject: [PATCH] Don't run GPU tests with strace. We usually only need the "nvproxy: " logs to debug GPU workload issues. These are visible with --debug=true itself. Strace makes things really slow. And consistently run "All GPU Drivers Test" with --debug=true. PiperOrigin-RevId: 633199684 --- .buildkite/pipeline.yaml | 6 +++--- tools/gpu/all_drivers_test.sh | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.buildkite/pipeline.yaml b/.buildkite/pipeline.yaml index 633ffab32..428d66d2f 100644 --- a/.buildkite/pipeline.yaml +++ b/.buildkite/pipeline.yaml @@ -174,7 +174,7 @@ steps: label: ":firefighter: GPU Smoke Tests" commands: - make sudo TARGETS=//tools/gpu:main ARGS="install --latest" || cat /var/log/nvidia-installer.log - - make gpu-smoke-tests RUNTIME_ARGS="--strace --debug" + - make gpu-smoke-tests RUNTIME_ARGS="--debug" agents: queue: gpu - <<: *common @@ -182,14 +182,14 @@ steps: label: ":screwdriver: GPU Tests" commands: - make sudo TARGETS=//tools/gpu:main ARGS="install --latest" || cat /var/log/nvidia-installer.log - - make gpu-all-tests RUNTIME_ARGS="--strace --debug" + - make gpu-all-tests RUNTIME_ARGS="--debug" agents: queue: gpu - <<: *common <<: *source_test_continuous label: ":female_supervillain: COS GPU Tests" commands: - - make cos-gpu-all-tests RUNTIME_ARGS="--strace --debug" + - make cos-gpu-all-tests RUNTIME_ARGS="--debug" agents: queue: cos-canary-gpu - <<: *common diff --git a/tools/gpu/all_drivers_test.sh b/tools/gpu/all_drivers_test.sh index 327d0095b..de31e80e8 100755 --- a/tools/gpu/all_drivers_test.sh +++ b/tools/gpu/all_drivers_test.sh @@ -26,5 +26,5 @@ read -r -a versions <<< "$(cat "${tmp_file}")" for driver in "${versions[@]}"; do make sudo TARGETS=tools/gpu:main ARGS="install --version ${driver}" - make gpu-smoke-tests + make gpu-smoke-tests RUNTIME_ARGS="--debug" done