From 3885a281f2ae55f1bf04eaa08015fbe5c4b7917c Mon Sep 17 00:00:00 2001 From: Jamie Liu Date: Fri, 28 Feb 2025 11:01:43 -0800 Subject: [PATCH] test: add syscall_test() perf argument PiperOrigin-RevId: 732194076 --- test/perf/BUILD | 104 +++++++++++-------------------------------- test/runner/defs.bzl | 17 ++++++- 2 files changed, 41 insertions(+), 80 deletions(-) diff --git a/test/perf/BUILD b/test/perf/BUILD index be284659a..934e24210 100644 --- a/test/perf/BUILD +++ b/test/perf/BUILD @@ -7,69 +7,51 @@ package( ) syscall_test( - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:clock_getres_benchmark", ) syscall_test( - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:clock_gettime_benchmark", ) syscall_test( - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:death_benchmark", ) syscall_test( - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:epoll_benchmark", ) syscall_test( - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:poll_benchmark", ) syscall_test( - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:select_benchmark", ) syscall_test( size = "large", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:fork_benchmark", ) syscall_test( size = "large", timeout = "long", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:futex_benchmark", ) syscall_test( size = "large", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, shard_count = more_shards, tags = ["nogotsan"], test = "//test/perf/linux:getdents_benchmark", @@ -77,136 +59,104 @@ syscall_test( syscall_test( size = "large", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:getpid_benchmark", ) syscall_test( size = "large", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, tags = ["nogotsan"], test = "//test/perf/linux:gettid_benchmark", ) syscall_test( size = "large", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:mapping_benchmark", ) syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:open_benchmark", ) syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:open_read_close_benchmark", ) syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:dup_benchmark", ) syscall_test( - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:pipe_benchmark", ) syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:randread_benchmark", ) syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:read_benchmark", ) syscall_test( size = "large", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:sched_yield_benchmark", ) syscall_test( size = "large", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:send_recv_benchmark", ) syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:seqwrite_benchmark", ) syscall_test( size = "large", - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:signal_benchmark", ) syscall_test( - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:sleep_benchmark", ) syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:stat_benchmark", ) syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, tags = ["nogotsan"], test = "//test/perf/linux:unlink_benchmark", ) @@ -214,8 +164,6 @@ syscall_test( syscall_test( size = "large", add_overlay = True, - debug = False, - # Takes too long to run with S/R. - save = False, + perf = True, test = "//test/perf/linux:write_benchmark", ) diff --git a/test/runner/defs.bzl b/test/runner/defs.bzl index de94bb56e..66a508b2b 100644 --- a/test/runner/defs.bzl +++ b/test/runner/defs.bzl @@ -374,13 +374,14 @@ def syscall_test( iouring = False, allow_native = True, leak_check = True, - debug = True, + debug = None, container = None, tags = None, - save = True, + save = None, size = "medium", overlay = False, netstack_sr = False, + perf = False, **kwargs): """syscall_test is a macro that will create targets for all platforms. @@ -403,11 +404,23 @@ def syscall_test( leak_check: enables leak check. save: enables save/restore and save/resume test variants. size: test size. + overlay: add overlayfs test variants. + netstack_sr: if save is true, add netstack save/restore test variants. + perf: test is a benchmark. **kwargs: additional test arguments. """ if not tags: tags = [] + # Debug logs and save/save_resume test variants are disabled by default for + # benchmarks and enabled by default otherwise. + if debug == None: + debug = not perf + if save == None: + save = not perf + if perf: + tags.append("perf") + if allow_native: _syscall_test( test = test,