From 2bb73c7bd7dcf0b36e774d8e82e464d04bc81f4b Mon Sep 17 00:00:00 2001
From: Fabricio Voznika <fvoznika@google.com>
Date: Mon, 15 Aug 2022 18:11:20 -0700
Subject: [PATCH] Add output to `runsc trace` commands

Otherwise it's hard to tell if the command succeeded or not.

Updates #4805

PiperOrigin-RevId: 467807571
---
 runsc/cmd/trace/create.go |  1 +
 runsc/cmd/trace/delete.go | 11 +++++++----
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/runsc/cmd/trace/create.go b/runsc/cmd/trace/create.go
index fdfd440fc..59b4ccb1d 100644
--- a/runsc/cmd/trace/create.go
+++ b/runsc/cmd/trace/create.go
@@ -90,6 +90,7 @@ func (l *create) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}
 		util.Fatalf("creating session: %v", err)
 	}
 
+	fmt.Printf("Trace session %q created.\n", sessionConfig.Name)
 	return subcommands.ExitSuccess
 }
 
diff --git a/runsc/cmd/trace/delete.go b/runsc/cmd/trace/delete.go
index 08f1bc0b7..76ae0eb6a 100644
--- a/runsc/cmd/trace/delete.go
+++ b/runsc/cmd/trace/delete.go
@@ -16,6 +16,7 @@ package trace
 
 import (
 	"context"
+	"fmt"
 
 	"github.com/google/subcommands"
 	"gvisor.dev/gvisor/runsc/cmd/util"
@@ -26,7 +27,7 @@ import (
 
 // delete implements subcommands.Command for the "delete" command.
 type delete struct {
-	name string
+	sessionName string
 }
 
 // Name implements subcommands.Command.
@@ -47,7 +48,7 @@ func (*delete) Usage() string {
 
 // SetFlags implements subcommands.Command.
 func (l *delete) SetFlags(f *flag.FlagSet) {
-	f.StringVar(&l.name, "name", "", "name of session to be deleted")
+	f.StringVar(&l.sessionName, "name", "", "name of session to be deleted")
 }
 
 // Execute implements subcommands.Command.
@@ -56,7 +57,7 @@ func (l *delete) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}
 		f.Usage()
 		return subcommands.ExitUsageError
 	}
-	if len(l.name) == 0 {
+	if len(l.sessionName) == 0 {
 		f.Usage()
 		return util.Errorf("missing session name, please set --name")
 	}
@@ -73,8 +74,10 @@ func (l *delete) Execute(_ context.Context, f *flag.FlagSet, args ...interface{}
 		util.Fatalf("loading sandbox: %v", err)
 	}
 
-	if err := c.Sandbox.DeleteTraceSession(l.name); err != nil {
+	if err := c.Sandbox.DeleteTraceSession(l.sessionName); err != nil {
 		util.Fatalf("deleting session: %v", err)
 	}
+
+	fmt.Printf("Trace session %q deleted.\n", l.sessionName)
 	return subcommands.ExitSuccess
 }