From 26a5961d4daad4fd55ca5319df29fe28d9412d35 Mon Sep 17 00:00:00 2001
From: Ayush Ranjan <ayushranjan@google.com>
Date: Thu, 30 Mar 2023 14:35:13 -0700
Subject: [PATCH] Print flags as hex or octal values in lisafs messages.

This makes RPC logs more readable.

PiperOrigin-RevId: 520745226
---
 pkg/lisafs/message.go | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/pkg/lisafs/message.go b/pkg/lisafs/message.go
index 786d388f7..e000b6ea5 100644
--- a/pkg/lisafs/message.go
+++ b/pkg/lisafs/message.go
@@ -669,7 +669,7 @@ type OpenAtReq struct {
 
 // String implements fmt.Stringer.String.
 func (o *OpenAtReq) String() string {
-	return fmt.Sprintf("OpenAtReq{FD: %d, Flags: %d}", o.FD, o.Flags)
+	return fmt.Sprintf("OpenAtReq{FD: %d, Flags: %#o}", o.FD, o.Flags)
 }
 
 // OpenAtResp is used to communicate the newly created FD.
@@ -704,7 +704,7 @@ type OpenCreateAtReq struct {
 
 // String implements fmt.Stringer.String.
 func (o *OpenCreateAtReq) String() string {
-	return fmt.Sprintf("OpenCreateAtReq{DirFD: %d, Mode: %s, UID: %d, GID: %d, Flags: %d, Name: %s}", o.DirFD, o.Mode, o.UID, o.GID, o.Flags, o.Name)
+	return fmt.Sprintf("OpenCreateAtReq{DirFD: %d, Mode: %s, UID: %d, GID: %d, Flags: %#o, Name: %s}", o.DirFD, o.Mode, o.UID, o.GID, o.Flags, o.Name)
 }
 
 // SizeBytes implements marshal.Marshallable.SizeBytes.
@@ -1437,7 +1437,7 @@ type UnlinkAtReq struct {
 
 // String implements fmt.Stringer.String.
 func (u *UnlinkAtReq) String() string {
-	return fmt.Sprintf("UnlinkAtReq{DirFD: %d, Flags: %d, Name: %s}", u.DirFD, u.Flags, u.Name)
+	return fmt.Sprintf("UnlinkAtReq{DirFD: %d, Flags: %#x, Name: %s}", u.DirFD, u.Flags, u.Name)
 }
 
 // SizeBytes implements marshal.Marshallable.SizeBytes.
@@ -1729,7 +1729,7 @@ type FSetXattrReq struct {
 
 // String implements fmt.Stringer.String.
 func (s *FSetXattrReq) String() string {
-	return fmt.Sprintf("FSetXattrReq{FD: %d, Flags: %d, Name: %s, Value: %s}", s.FD, s.Flags, s.Name, s.Value)
+	return fmt.Sprintf("FSetXattrReq{FD: %d, Flags: %#x, Name: %s, Value: %s}", s.FD, s.Flags, s.Name, s.Value)
 }
 
 // SizeBytes implements marshal.Marshallable.SizeBytes.