From 1910a4577f0183bf444660985f30dc78ef3a74ca Mon Sep 17 00:00:00 2001 From: Jamie Liu Date: Tue, 12 Sep 2023 11:26:44 -0700 Subject: [PATCH] cgroupfs: do not return errors from strconv.ParseInt() to write() Arbitrary errors are not convertible to errnos for syscall return and cause the sentry to panic. PiperOrigin-RevId: 564782206 --- pkg/sentry/fsimpl/cgroupfs/devices.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/sentry/fsimpl/cgroupfs/devices.go b/pkg/sentry/fsimpl/cgroupfs/devices.go index efec8b6f8..efdbe2f02 100644 --- a/pkg/sentry/fsimpl/cgroupfs/devices.go +++ b/pkg/sentry/fsimpl/cgroupfs/devices.go @@ -366,7 +366,7 @@ func toDeviceNumber(s string) (int64, error) { } val, err := strconv.ParseInt(s, 10, 64) if err != nil { - return 0, err + return 0, linuxerr.EINVAL } return val, nil }