From 155cdcb458e8e6f1ce0ca017d82f41a528cbeace Mon Sep 17 00:00:00 2001 From: Jing Chen Date: Thu, 7 Nov 2024 16:01:48 -0800 Subject: [PATCH] Make buildkite push images with `gcr.io` at release pipeline. GCR will be deprecated, while the prefix `gcr.io` will be be hosted via Artifact Registry. By adding this one extra step, all test images will be accessible via both `gcr.io` and `pkg.dev`. PiperOrigin-RevId: 694278137 --- .buildkite/release.yaml | 2 ++ images/README.md | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.buildkite/release.yaml b/.buildkite/release.yaml index 186a1da9f..94d54f9d9 100644 --- a/.buildkite/release.yaml +++ b/.buildkite/release.yaml @@ -24,6 +24,7 @@ steps: if: build.branch == "master" && build.tag == null commands: - make ARCH=x86_64 DOCKER_PUSH_AS_LATEST=true push-all-images + - make ARCH=x86_64 REMOTE_IMAGE_PREFIX=gcr.io/gvisor-presubmit DOCKER_PUSH_AS_LATEST=true push-all-images agents: arch: "amd64" - <<: *common @@ -31,6 +32,7 @@ steps: if: build.branch == "master" && build.tag == null commands: - make ARCH=aarch64 DOCKER_PUSH_AS_LATEST=true push-all-images + - make ARCH=aarch64 REMOTE_IMAGE_PREFIX=gcr.io/gvisor-presubmit DOCKER_PUSH_AS_LATEST=true push-all-images agents: arch: "arm64" - <<: *common diff --git a/images/README.md b/images/README.md index 5784341e9..83e681d47 100644 --- a/images/README.md +++ b/images/README.md @@ -52,9 +52,8 @@ if available. ## Building and pushing images All images can be built manually by running `build-` and pushed using -`push-`. Note that you can also use `build-all-images` and -`push-all-images`. Note that pushing will require appropriate permissions in the -project. +`push-`. Note that you can also use `push-all-images`. Note that pushing +will require appropriate permissions in the project. The continuous integration system can either take fine-grained dependencies on individual `push` targets, or ensure all images are up-to-date with a single